extra check not recording property incase of video recording is false #13475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkarkhatavkar
added
CherryPick
jyejare
reviewed
Dec 15, 2023
robottelo/hosts.py
Outdated
| @@ -1849,8 +1849,9 @@ def get_caller(): | |||
| video_url = settings.ui.grid_url.replace( | |||
| ':4444', f'/videos/{ui_session.ui_session_id}.mp4' | |||
| ) | |||
| self.record_property('video_url', video_url) | |||
| self.record_property('session_id', ui_session.ui_session_id) | |||
| if not self.record_property and settings.ui.record_video: | |||
There was a problem hiding this comment.
IMHO check forself.record_property to be none is not required because this could have been already populated when nested/multiple session would be running for a test for same satellite ?
There was a problem hiding this comment.
I wanted to prevent a scenario where the test passes, but the record property for that specific SAT instance doesn't get retrieved somehow. Omitting this condition could lead to test failures.
To address this, I can include a warning message or logging mechanism if such a situation occurs. Another approach is to detect this issue through failing UI tests when the UI recording session cannot be obtained. This will avoid the side effects in this case. We are not going to often see this issue.
JacobCallahan
approved these changes
Dec 22, 2023
omkarkhatavkar
force-pushed
the
extra_check_video_recording
branch
from
610130c to
1349c4f
Compare
jyejare
approved these changes
Dec 27, 2023
Gauravtalreja1
pushed a commit
that referenced
this pull request
Dec 27, 2023
… is false (#13561) extra check not recording property incase of video recording is false (#13475) (cherry picked from commit 61219a1) Co-authored-by: Omkar Khatavkar <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Dec 27, 2023
… is false (#13564) extra check not recording property incase of video recording is false (#13475) (cherry picked from commit 61219a1) Co-authored-by: Omkar Khatavkar <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Dec 27, 2023
… is false (#13563) extra check not recording property incase of video recording is false (#13475) (cherry picked from commit 61219a1) Co-authored-by: Omkar Khatavkar <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Dec 27, 2023
… is false (#13562) extra check not recording property incase of video recording is false (#13475) (cherry picked from commit 61219a1) Co-authored-by: Omkar Khatavkar <[email protected]>
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Currently, every time we record a video URL is a JUnit report, which is not necessary in case the video recording is false.
Solution
Adding extra layer check to see record_property is not null and video recording is true