Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and simplify ping test #13489

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

rmynar
Copy link
Contributor

@rmynar rmynar commented Dec 18, 2023

Cache status was added to hammer ping output and there can be more cache servers configured so the output syntax has changed. I changed and simplified the test so it can parse current output and it also meets test description.

sample output:

database:         
    Status:          ok
    Server Response: Duration: 0ms
cache:            
    servers: 
     1) Status:          ok
        Server Response: Duration: 0ms
candlepin:        
    Status:          ok
    Server Response: Duration: 23ms
...

PS: I'm not aware of negative scenario for this testcase (i.e. scenario when some of Satellite services report status "FAIL"). We may add it in future.

@rmynar rmynar requested a review from a team as a code owner December 18, 2023 15:40
@rmynar rmynar added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 18, 2023
@rmynar
Copy link
Contributor Author

rmynar commented Dec 18, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_ping.py

tests/foreman/cli/test_ping.py Outdated Show resolved Hide resolved
tests/foreman/cli/test_ping.py Outdated Show resolved Hide resolved
@rmynar rmynar force-pushed the ping_refactor_cache_status branch from 812a49d to aeede50 Compare January 11, 2024 15:02
@ogajduse ogajduse enabled auto-merge (rebase) January 11, 2024 15:08
@ogajduse ogajduse merged commit d984b2b into SatelliteQE:master Jan 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants