Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cli errata tests and update cli factory method #13505

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix cli errata tests and update cli factory method #13505

merged 1 commit into from
Dec 22, 2023

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Dec 19, 2023 •
edited
Loading

Problem Statement

Com eval - 2 tests were failing due to cli factory method > setup_org_for_a_rh_repo with error mentioned below
test_positive_list_filter_by_org_sort_by_date
test_positive_list_filter_by_cve

Error:

E AttributeError: 'Manifest' object has no attribute 'path'

Solution

Basically due to old way of cloning and uploading manifest into the satellite didn't work, also as per 6.15.z and later version of satellite *_sca_manifest_org fixture is supposed to be used.
With this fix above 2 tests and couple of few tests are expected to get fix.

Related Issues

The below 2 tests will get benifit of the change made in cli_factory and will pass accordingly.
cli.test_activationkey.py > test_positive_subscription_quantity_attached
cli.test_host.py > test_negative_without_attach_with_lce

@vijaysawant vijaysawant requested review from a team as code owners December 19, 2023 15:39
@vijaysawant vijaysawant marked this pull request as draft December 19, 2023 15:39
@vijaysawant vijaysawant added Stream Introduced in or relating directly to Satellite Stream/Master 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches labels Dec 19, 2023
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py -k "test_positive_list_filter_by_org_sort_by_date" -k "test_positive_list_filter_by_cve"

@damoore044
Copy link
Contributor

damoore044 commented Dec 19, 2023 •
edited
Loading

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py -k 'test_positive_list_filter_by_org_sort_by_date or test_positive_list_filter_by_cve'

damoore044
damoore044 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on these!

vsedmik
vsedmik reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see those tests passing again, just one small concern about the manifest to consider.

robottelo/host_helpers/cli_factory.py Show resolved Hide resolved
@vijaysawant vijaysawant force-pushed the comp_eval_cli_errata_manifest_issue branch from 1b6cc16 to d31a10d Compare December 21, 2023 15:15
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py -k 'test_positive_list_filter_by_org_sort_by_date or test_positive_list_filter_by_cve'

@vijaysawant vijaysawant force-pushed the comp_eval_cli_errata_manifest_issue branch from d31a10d to f5e764a Compare December 22, 2023 14:10
@vsedmik
Copy link
Contributor

vsedmik commented Dec 22, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_errata.py -k 'test_positive_list_filter_by_org_sort_by_date or test_positive_list_filter_by_cve'

vsedmik
vsedmik approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, PRT pending

@vijaysawant vijaysawant marked this pull request as ready for review December 22, 2023 14:13
@vijaysawant vijaysawant added AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing TestFailure Issues and PRs related to a test failing in automation labels Dec 22, 2023
@omkarkhatavkar omkarkhatavkar merged commit bf97bdb into SatelliteQE:master Dec 22, 2023
9 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@vijaysawant @web-flow
fix cli errata tests and update cli factory method (#13505)
c96f5af 
(cherry picked from commit bf97bdb)
@Satellite-QE Satellite-QE mentioned this pull request Dec 22, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@vijaysawant @web-flow
fix cli errata tests and update cli factory method (#13505)
f8842c1 
(cherry picked from commit bf97bdb)
@Satellite-QE Satellite-QE mentioned this pull request Dec 22, 2023
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vijaysawant @shweta83
fix cli errata tests and update cli factory method (SatelliteQE#13505)
4ffeabd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@vsedmik vsedmik vsedmik approved these changes

Assignees

@vijaysawant vijaysawant

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vijaysawant @damoore044 @vsedmik @omkarkhatavkar