Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISS Network Sync class and basic scenario #13543

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Dec 21, 2023

Problem Statement

Network Sync functionality of ISS hasn't been automated yet, coverage is missing.

Solution

This PR adds new class with first scenario to cover Network Sync. The previous classes will be refactored in one of next PRs since they don't reflect the reality and the change should be CPed deeper than this PR is.

Related Issues

Covers this customer case BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2213128

@vsedmik vsedmik added QETestCoverage Issues and PRs relating to a Satellite bug CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 21, 2023
@vsedmik vsedmik self-assigned this Dec 21, 2023
@vsedmik vsedmik requested review from a team as code owners December 21, 2023 14:34
@vsedmik
Copy link
Contributor Author

vsedmik commented Dec 21, 2023

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_network_sync_rh_repo

Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Comment on lines +2067 to +2069
module_satellite_host.cli.Settings.set(
{'name': 'subscription_connection_enabled', 'value': 'No'}
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need an teardown for this to change back to Yes (if default)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. On the downstream sat we always need this off.

@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 2, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_satellitesync.py -k test_positive_network_sync_rh_repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants