Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Add coverage for HTTP Proxy capsule install #13693

Closed
wants to merge 1 commit into from
Closed

[6.14.z] Add coverage for HTTP Proxy capsule install #13693

wants to merge 1 commit into from

Conversation

Griffin-Sullivan
Copy link
Contributor

Problem Statement

6.14.z Manual cherry-pick for https://github.com/SatelliteQE/robottelo/pull/13507/commits

Solution

Related Issues

@Griffin-Sullivan Griffin-Sullivan added No-CherryPick PR doesnt need CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 labels Jan 9, 2024
@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_capsule_installation

@Griffin-Sullivan Griffin-Sullivan linked an issue Jan 9, 2024 that may be closed by this pull request
[Failed-AutoCherryPick] - Add coverage for HTTP Proxy capsule install #13607
Closed
@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_capsule_installation

1 similar comment
@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_capsule_installation

@Griffin-Sullivan Griffin-Sullivan marked this pull request as draft January 11, 2024 19:25
@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_capsule_installation

1 similar comment
@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_capsule_installation

@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_capsule_installation

Gauravtalreja1
Gauravtalreja1 requested changes Feb 9, 2024
View reviewed changes
tests/foreman/installer/test_installer.py
Comment on lines +1398 to +1401
@pytest.mark.parametrize(
'setting_update', [f'http_proxy={settings.http_proxy.un_auth_proxy_url}'], indirect=True
)
def test_capsule_installation(sat_default_install, cap_ready_rhel, setting_update):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRT failed with AssertionError, is this a known issue or due to any BZ? if not, I think it should be reported

        # no errors/failures in /var/log/candlepin/*
        result = satellite.execute(r'grep -iR "error" /var/log/candlepin/*')
>       assert len(result.stdout) == 0
E       assert 2360 == 0
E        +  where 2360 = len('/var/log/candlepin/candlepin.log:2024-02-08 14:39:41,272 [thread=Thread-4 (ActiveMQ-client-global-threads)] [=, org=,...d=] ERROR org.candlepin.audit.DefaultEventMessageReceiver - Unable to process message 97: argument "content" is null\n')
E        +    where '/var/log/candlepin/candlepin.log:2024-02-08 14:39:41,272 [thread=Thread-4 (ActiveMQ-client-global-threads)] [=, org=,...d=] ERROR org.candlepin.audit.DefaultEventMessageReceiver - Unable to process message 97: argument "content" is null\n' = stdout:\n/var/log/candlepin/candlepin.log:2024-02-08 14:39:41,272 [thread=Thread-4 (ActiveMQ-client-global-threads)] [=...udit.DefaultEventMessageReceiver - Unable to process message 97: argument "content" is null\n\nstderr:\n(0, b'')\nstatus: 0.stdout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been reported to the candlepin team and I think they are backporting it. I'll have to check again it's been a little while.

@Griffin-Sullivan
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_capsule_installation

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5803
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/installer/test_installer.py::test_capsule_installation
Test Result : ============== 1 passed, 1 warning, 1 error in 3174.74s (0:52:54) ==============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

This pull request has not been updated in the past 45 days.

@github-actions github-actions bot added the Stale Stale issue or Pull Request label Apr 6, 2024
@github-actions GitHub Actions
Copy link

This pull request is now being closed after stale warnings.

@github-actions github-actions bot closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 requested changes

Assignees

@Griffin-Sullivan Griffin-Sullivan

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stale Stale issue or Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed-AutoCherryPick] - Add coverage for HTTP Proxy capsule install
3 participants
@Griffin-Sullivan @Gauravtalreja1 @Satellite-QE