Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.14.z] Add coverage for HTTP Proxy capsule install #13693

Closed
wants to merge 1 commit into from
Closed

[6.14.z] Add coverage for HTTP Proxy capsule install #13693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytest_fixtures/core/sat_cap_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ def module_sat_ready_rhels(request):

@pytest.fixture
def cap_ready_rhel():
rhel_version = Version(settings.capsule.version.release)
rhel_version = Version(settings.capsule.version.rhel_version)
deploy_args = {
'deploy_rhel_version': rhel_version.base_version,
'deploy_flavor': settings.flavors.default,
Expand Down
9 changes: 8 additions & 1 deletion tests/foreman/installer/test_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,7 +1395,10 @@ def sat_non_default_install(module_sat_ready_rhels):
@pytest.mark.e2e
@pytest.mark.tier1
@pytest.mark.pit_client
def test_capsule_installation(sat_default_install, cap_ready_rhel, default_org):
@pytest.mark.parametrize(
'setting_update', [f'http_proxy={settings.http_proxy.un_auth_proxy_url}'], indirect=True
)
def test_capsule_installation(sat_default_install, cap_ready_rhel, setting_update):
Comment on lines +1398 to +1401
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRT failed with AssertionError, is this a known issue or due to any BZ? if not, I think it should be reported

        # no errors/failures in /var/log/candlepin/*
        result = satellite.execute(r'grep -iR "error" /var/log/candlepin/*')
>       assert len(result.stdout) == 0
E       assert 2360 == 0
E        +  where 2360 = len('/var/log/candlepin/candlepin.log:2024-02-08 14:39:41,272 [thread=Thread-4 (ActiveMQ-client-global-threads)] [=, org=,...d=] ERROR org.candlepin.audit.DefaultEventMessageReceiver - Unable to process message 97: argument "content" is null\n')
E        +    where '/var/log/candlepin/candlepin.log:2024-02-08 14:39:41,272 [thread=Thread-4 (ActiveMQ-client-global-threads)] [=, org=,...d=] ERROR org.candlepin.audit.DefaultEventMessageReceiver - Unable to process message 97: argument "content" is null\n' = stdout:\n/var/log/candlepin/candlepin.log:2024-02-08 14:39:41,272 [thread=Thread-4 (ActiveMQ-client-global-threads)] [=...udit.DefaultEventMessageReceiver - Unable to process message 97: argument "content" is null\n\nstderr:\n(0, b'')\nstatus: 0.stdout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been reported to the candlepin team and I think they are backporting it. I'll have to check again it's been a little while.

"""Run a basic Capsule installation

:id: 64fa85b6-96e6-4fea-bea4-a30539d59e65
Expand All @@ -1412,6 +1415,10 @@ def test_capsule_installation(sat_default_install, cap_ready_rhel, default_org):
3. health check runs successfully

:CaseImportance: Critical

:BZ: 1984400

:customerscenario: true
"""
# Get Capsule repofile, and enable and download satellite-capsule
cap_ready_rhel.register_to_cdn()
Expand Down
Loading