Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup video recording #13713

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Cleanup video recording #13713

merged 1 commit into from
Jan 12, 2024

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Jan 10, 2024 •
edited
Loading

Problem Statement

  • missing ui setting record_video breaks tests
  • robottelo tests fail in teardwon despite record_video is set to false

Solution

  • Only call related functionality when record_video is set to true
  • Add settings options to config template

Related Issues

@dosas dosas requested a review from a team as a code owner January 10, 2024 10:23
@Gauravtalreja1 Gauravtalreja1 added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 and removed 6.12.z Introduced in or relating directly to Satellite 6.12 labels Jan 10, 2024
@dosas dosas force-pushed the feature/cleanup-video-recording branch 2 times, most recently from 85a3720 to 27b1dae Compare January 10, 2024 14:32
@omkarkhatavkar
Copy link

@dosas can you please rebase it? I updated the correct URLs.

Cleanup video recording
ecad5fa 
* Only call related functionallity when
  record_video is set to true
* Add settings options to config template
@dosas dosas force-pushed the feature/cleanup-video-recording branch from 27b1dae to ecad5fa Compare January 11, 2024 09:29
@dosas
Copy link
Collaborator Author

dosas commented Jan 11, 2024

@omkarkhatavkar Rebased your changes

@omkarkhatavkar
Copy link

trigger: test-robottelo
pytest: tests/foreman/ui/test_ldap_authentication.py -k test_positive_delete_external_roles
pod_resources_size: extra_large
env:
ROBOTTELO_ui__record_video: true

@omkarkhatavkar omkarkhatavkar merged commit ad6b99f into SatelliteQE:master Jan 12, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
@dosas @web-flow
Cleanup video recording (#13713)
e05f955 
* Only call related functionallity when
  record_video is set to true
* Add settings options to config template

Co-authored-by: dosas <[email protected]>
(cherry picked from commit ad6b99f)
@Satellite-QE Satellite-QE mentioned this pull request Jan 12, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
@dosas @web-flow
Cleanup video recording (#13713)
2cd7dc4 
* Only call related functionallity when
  record_video is set to true
* Add settings options to config template

Co-authored-by: dosas <[email protected]>
(cherry picked from commit ad6b99f)
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
@dosas @web-flow
Cleanup video recording (#13713)
3738e59 
* Only call related functionallity when
  record_video is set to true
* Add settings options to config template

Co-authored-by: dosas <[email protected]>
(cherry picked from commit ad6b99f)
This was referenced Jan 12, 2024
Merged
Merged
Gauravtalreja1 pushed a commit that referenced this pull request Jan 12, 2024
@Satellite-QE @dosas
[6.15.z] Cleanup video recording (#13771)
159a0a3 
Cleanup video recording (#13713)

* Only call related functionallity when
  record_video is set to true
* Add settings options to config template

Co-authored-by: dosas <[email protected]>
(cherry picked from commit ad6b99f)

Co-authored-by: dosas <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Jan 12, 2024
@Satellite-QE @dosas
[6.14.z] Cleanup video recording (#13770)
f78b348 
Cleanup video recording (#13713)

* Only call related functionallity when
  record_video is set to true
* Add settings options to config template

Co-authored-by: dosas <[email protected]>
(cherry picked from commit ad6b99f)

Co-authored-by: dosas <[email protected]>
Gauravtalreja1 pushed a commit that referenced this pull request Jan 12, 2024
@Satellite-QE @dosas
[6.13.z] Cleanup video recording (#13769)
9289723 
Cleanup video recording (#13713)

* Only call related functionallity when
  record_video is set to true
* Add settings options to config template

Co-authored-by: dosas <[email protected]>
(cherry picked from commit ad6b99f)

Co-authored-by: dosas <[email protected]>
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@dosas @shweta83
Cleanup video recording (SatelliteQE#13713)
9ae1f1d 
* Only call related functionallity when
  record_video is set to true
* Add settings options to config template

Co-authored-by: dosas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees

@dosas dosas

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dosas @omkarkhatavkar @Gauravtalreja1