Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in cli_factory #13738

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fixes in cli_factory #13738

merged 2 commits into from
Jan 11, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jan 11, 2024

Try to run the test_dummie with and without the changes.

For the csv format you get:

E   ValueError: zip() argument 2 is shorter than argument 1

For the @lru_cache present you get:

E           Could not create the repository:
E             Validation failed: Name has already been taken for this product., Label has already been taken for this product., Download policy Cannot set attribute download_policy for content type file

@vsedmik vsedmik added Framework Changes A modification of the robottelo framework CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 11, 2024
@vsedmik vsedmik self-assigned this Jan 11, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented Jan 11, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_capsulecontent.py -k dummie

@vsedmik vsedmik requested a review from JacobCallahan January 11, 2024 10:40
@vsedmik vsedmik mentioned this pull request Jan 11, 2024
Merged
@vsedmik
Fixes in cli_factory
8a9bbc6 
- remove @lru_cache from CLIFactory.__getattr__
- flip output format of cli.Repository.synchronize to from 'csv'
  to 'base' (output is not in csv format here)
@vsedmik
Remmove the test_dummie
0954885
@vsedmik vsedmik marked this pull request as ready for review January 11, 2024 14:37
@vsedmik vsedmik requested a review from a team as a code owner January 11, 2024 14:37
@JacobCallahan JacobCallahan merged commit 99df502 into SatelliteQE:master Jan 11, 2024
6 checks passed
This was referenced Jan 11, 2024
Closed
Closed
Closed
Closed
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
jyejare
jyejare reviewed Jan 12, 2024
View reviewed changes
robottelo/cli/repository.py
@@ -60,7 +60,7 @@ def synchronize(cls, options, return_raw_response=None, timeout=3600000):
cls.command_sub = 'synchronize'
return cls.execute(
cls._construct_command(options),
output_format='csv',
output_format='base',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsedmik This has been fixed in #13737 . You should not need this w/o anymore!

@Satellite-QE Satellite-QE mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyejare jyejare jyejare left review comments

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@vsedmik vsedmik

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches Framework Changes A modification of the robottelo framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsedmik @JacobCallahan @jyejare