Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in test_permission #13871

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix in test_permission #13871

merged 1 commit into from
Jan 23, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

#12989 swapped entities for target_sat.api but:

(Pdb) entities.ActivationKey
<class 'nailgun.entities.ActivationKey'>
(Pdb) target_sat.api.ActivationKey
<class 'robottelo.hosts.Satellite.api.<locals>.inject_config.<locals>.DecClass'>

which breaks the if condition in this test

Solution

Swapping back to entities, as it is still heavily used in that module. Deferring further changes to component evaluation

@pondrejk pondrejk added API Issues and PRs involving the API TestFailure Issues and PRs related to a test failing in automation CherryPick PR needs CherryPick to previous branches Auto_Cherry_Picked Automatically cherrypicked PR using GHA 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jan 23, 2024
@pondrejk pondrejk self-assigned this Jan 23, 2024
@pondrejk pondrejk requested a review from a team as a code owner January 23, 2024 11:46
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_permission.py -k test_positive_check_update[2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 API Issues and PRs involving the API Auto_Cherry_Picked Automatically cherrypicked PR using GHA CherryPick PR needs CherryPick to previous branches TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants