Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CV already published + single LCE #13972

Merged
merged 1 commit into from
Mar 7, 2024
Merged

CV already published + single LCE #13972

merged 1 commit into from
Mar 7, 2024

Conversation

lhellebr
Copy link
Contributor

@lhellebr lhellebr commented Feb 1, 2024

Problem Statement

Fix the test. CV is already published and promoted by setup_org_for_a_rh_repo. Also, don't use 2 LCEs needlessly.

@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 1, 2024
@lhellebr lhellebr requested a review from a team as a code owner February 1, 2024 18:58
@lhellebr
Copy link
Contributor Author

lhellebr commented Feb 1, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce

@lhellebr
Copy link
Contributor Author

lhellebr commented Feb 1, 2024

PRT requires #13970 to pass (but this PR can be merged before, these are 2 different bugs)

@lhellebr lhellebr marked this pull request as draft February 1, 2024 19:01
@lhellebr
Copy link
Contributor Author

lhellebr commented Feb 1, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce

@lhellebr lhellebr marked this pull request as ready for review February 2, 2024 17:19
@lhellebr
Copy link
Contributor Author

lhellebr commented Feb 2, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce

@lhellebr lhellebr mentioned this pull request Feb 12, 2024
Merged
@lhellebr lhellebr requested a review from a team February 12, 2024 12:59
jyejare
jyejare reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending comments and questions!

tests/foreman/cli/test_host.py
host_subscription_client,
function_org,
function_lce,
sca_enabled,
):
"""Attempt to enable a repository of a subscription that was not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the description wrt to SCA switch and expected results. Also good to have test name modified for sca switching!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I'll update :expectedresults: to reflect what we expect to happen with{,out} SCA.

I wouldn't change the test name though in order to keep history. I think it's descriptive enough as it is.

tests/foreman/cli/test_host.py Show resolved Hide resolved
tests/foreman/cli/test_host.py Outdated Show resolved Hide resolved
@jameerpathan111
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5806
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce
Test Result : ============= 1 failed, 1 passed, 40 warnings in 861.51s (0:14:21) =============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 20, 2024
@jameerpathan111
Copy link
Contributor

@lhellebr test_negative_without_attach_with_lce[rhel7_contenthost0-without_sca] is failing in PRT, can you take a look at it?

@lhellebr lhellebr requested a review from a team February 22, 2024 12:34
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5823
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce
Test Result : ============= 1 failed, 1 passed, 41 warnings in 836.78s (0:13:56) =============

@lhellebr
Copy link
Contributor Author

Reason is stream not supporting non-SCA. I will open a new PR for 6.15 and will remove non-SCA stuff from here.

@lhellebr
Copy link
Contributor Author

6.15 PR: #14181

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5840
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce
Test Result : ================== 1 passed, 13 warnings in 753.20s (0:12:33) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 26, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5860
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce --external-logging
Test Result : ================== 1 passed, 13 warnings in 739.21s (0:12:19) ==================

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5861
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce --external-logging
Test Result : ================== 1 passed, 13 warnings in 778.58s (0:12:58) ==================

ogajduse
ogajduse requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhellebr Can you please address @Gauravtalreja1's comments in #14181 and make the same changes in this PR?

@lhellebr
Copy link
Contributor Author

lhellebr commented Mar 4, 2024

Gaurav's comments addressed

@lhellebr
Copy link
Contributor Author

lhellebr commented Mar 4, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce

@lhellebr lhellebr requested a review from ogajduse March 4, 2024 13:01
@lhellebr
Copy link
Contributor Author

lhellebr commented Mar 4, 2024

CQ failure unrelated:

Collecting ssh2-python@ git+https://github.com/jacobcallahan/ssh2-python.git (from broker->-r requirements.txt (line 39))
  Cloning https://github.com/jacobcallahan/ssh2-python.git to /tmp/pip-install-3xy_w6ky/ssh2-python_269a23ab967b4dacbe0a9b24b9dd1ca4
  Running command git clone --filter=blob:none --quiet https://github.com/jacobcallahan/ssh2-python.git /tmp/pip-install-3xy_w6ky/ssh2-python_269a23ab967b4dacbe0a9b24b9dd1ca4
  Downloading ci/appveyor/zlib1211.zip (747 KB)
  Error downloading object: ci/appveyor/zlib1211.zip (d7510a8): Smudge error: Error downloading ci/appveyor/zlib1211.zip (d7510a8ee1918b7d0cad197a089c0a2cd4d6df05fee22389f67f115e738b178d): batch response: This repository is over its data quota. Account responsible for LFS bandwidth should purchase more data packs to restore access.

  Errors logged to '/tmp/pip-install-3xy_w6ky/ssh2-python_269a23ab967b4dacbe0a9b24b9dd1ca4/.git/lfs/logs/20240304T130152.688758585.log'.
  Use `git lfs logs last` to view the log.
  error: external filter 'git-lfs filter-process' failed
  fatal: ci/appveyor/zlib1211.zip: smudge filter lfs failed
  warning: Clone succeeded, but checkout failed.
  You can inspect what was checked out with 'git status'
  and retry with 'git restore --source=HEAD :/'

  error: subprocess-exited-with-error
  
  × git clone --filter=blob:none --quiet https://github.com/jacobcallahan/ssh2-python.git /tmp/pip-install-3xy_w6ky/ssh2-python_269a23ab967b4dacbe0a9b24b9dd1ca4 did not run successfully.
  │ exit code: 128
  ╰─> See above for output.
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× git clone --filter=blob:none --quiet https://github.com/jacobcallahan/ssh2-python.git /tmp/pip-install-3xy_w6ky/ssh2-python_269a23ab967b4dacbe0a9b24b9dd1ca4 did not run successfully.
│ exit code: 128
╰─> See above for output.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5925
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_negative_without_attach_with_lce --external-logging
Test Result : ================== 1 passed, 13 warnings in 813.13s (0:13:33) ==================

@Gauravtalreja1
Copy link
Collaborator

This was manually cherrypicked to 6.15.z by @lhellebr #14181, so we can remove cherrypick labels

@Gauravtalreja1 Gauravtalreja1 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master and removed CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Mar 4, 2024
@lhellebr
Fix the test. CV is already published and promoted by setup_org_for_a…
31d3de1 
…_rh_repo. Also, don't use 2 LCEs needlessly.
@lhellebr
Copy link
Contributor Author

lhellebr commented Mar 6, 2024

@ogajduse

@ogajduse ogajduse enabled auto-merge (squash) March 7, 2024 13:37
@lhellebr
Copy link
Contributor Author

lhellebr commented Mar 7, 2024

Waiting for @JacobCallahan to fix the CQ

@pnovotny
Copy link
Contributor

pnovotny commented Mar 7, 2024

Waiting for @JacobCallahan to fix the CQ

The PR JacobCallahan/ssh2-python#1 was merged yesterday and the CQ is fixed.
To trigger it again, you can rebase your PR and force-push it. It sould pass now.

@ogajduse ogajduse merged commit cfe2948 into SatelliteQE:master Mar 7, 2024
6 checks passed
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@lhellebr @shweta83
CV already published + single LCE (SatelliteQE#13972)
55634ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@ogajduse ogajduse ogajduse approved these changes

@jyejare jyejare jyejare approved these changes

@pnovotny pnovotny pnovotny approved these changes

Assignees

@lhellebr lhellebr

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lhellebr @jameerpathan111 @Satellite-QE @Gauravtalreja1 @pnovotny @jyejare @ogajduse