setup_org_for_a_rh_repo fix #13970
setup_org_for_a_rh_repo fix #13970
Conversation
lhellebr
added
CherryPick
|
Regression test, on a different test that uses It successfully fails the same way it fails without this PR, a few lines after a call for |
|
trigger: test-robottelo |
|
@lhellebr Could you check the failing PRT results? |
|
First failure is unrelated error fixed by #13972 . |
| ) | ||
| except CLIReturnCodeError as err: | ||
| raise CLIFactoryError(f'Failed to upload manifest\n{err.msg}') from err | ||
| self._satellite.upload_manifest(org_id, manifest.content) |
There was a problem hiding this comment.
@lhellebr I missed this earlier, similar changes are required for setup_org_for_a_rh_repo helper, could you update it too?
There was a problem hiding this comment.
Can we leave it for another PR? This PR is part of CE effort so I'm just doing what is required for that, changing as little as possible to minimize possibility of breaking stuff.
There was a problem hiding this comment.
@lhellebr Sure, please make a note of it or create a issue for it for future, and when you raise a PR to fix it, let me know, thank you!
Gauravtalreja1
added
Easy Fix :)
* setup_org_for_a_rh_repo fix * Use helper (cherry picked from commit 0e1e489)
setup_org_for_a_rh_repo fix (#13970) * setup_org_for_a_rh_repo fix * Use helper (cherry picked from commit 0e1e489) Co-authored-by: Lukáš Hellebrandt <[email protected]>
* setup_org_for_a_rh_repo fix * Use helper
Problem Statement
Solution
Follow idiom of creating a temporary file and into it, copying an in-memory object, then using it as a file.
I'm not sure how and when it got broken, I hit it when looking at the results of
test_negative_without_attach_with_lce. I haven't yet tested extensively to make sure this doesn't break function_setup_org_for_a_rh_repoin other cases but it seems like it couldn't have worked.