-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preserving PRT result as part of github comment & PRT pass/fail label #13979
Conversation
8cce48a
to
42fdaae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very useful addition to the Robottelo GH actions. I think it's a great idea to preserve the history of PRT requests in a PR's comments. However, I do have a few questions about your test results in omkarkhatavkar#158:
- In that PR, the build number for each run is reported as
10
. Is this due to repeatedly retriggering the same check from the same PRT run? - There's some inconsistency in the reported build status, with a mix of SUCCESS, FAILURE, and UNSTABLE reported for a build with a failed test. It looks like your most recent testing has converged on this result being reported as UNSTABLE, which I think is fine. But would it be possible to see results from a build showing a status of SUCCESS when all tests have passed?
- Which user account(s) will post the results comment to PRs when this is merged into Robottelo?
Thanks for seeing value in this PR (Contribution)
I was testing this that's why it would have repeatedly shown build number 10, In real case it will be the build number coming from the Jenkins PRT run.
I was just testing some dummy data, But the thumb rule is that if the test passes without any issues and the build is a Success it will present the label as PRT Passed, else PRT Failed. Adding more color code will look a bit better
The result will be posted by the token which I'm using here which is SatelliteQE user. |
omkarkhatavkar#158 (comment) This one the last comment by me. I think this looks much better as well |
42fdaae
to
1e0986c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great! Some nitpick comments.
37bec23
to
588f745
Compare
I have an ACK. |
@jyejare Can we merge this beast ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK pending comment !
588f745
to
5114480
Compare
@jyejare Could you please create labels for |
@omkarkhatavkar Added the labels for both! Now we should be good to merge if no complaints !! |
5114480
to
1c66380
Compare
…SatelliteQE#13979) preserving the PRT result as part of github comment & PRT pass/fail label
…ail label (#14039) preserving PRT result as part of github comment & PRT pass/fail label (#13979) preserving the PRT result as part of github comment & PRT pass/fail label (cherry picked from commit 2d0fed6) Co-authored-by: Omkar Khatavkar <[email protected]>
…ail label (#14038) preserving PRT result as part of github comment & PRT pass/fail label (#13979) preserving the PRT result as part of github comment & PRT pass/fail label (cherry picked from commit 2d0fed6) Co-authored-by: Omkar Khatavkar <[email protected]>
…ail label (#14037) preserving PRT result as part of github comment & PRT pass/fail label (#13979) preserving the PRT result as part of github comment & PRT pass/fail label (cherry picked from commit 2d0fed6) Co-authored-by: Omkar Khatavkar <[email protected]>
…SatelliteQE#13979) preserving the PRT result as part of github comment & PRT pass/fail label
Problem Statement
Currently, the PRT result gets clean after a new commit and there is no way for PR to know what happened with the result. PRT passed/failed labels also need to be added automatically this helps in reviewing the PR quickly and merging them
Solution
Add the dispatch workflow that takes care of this thing from the Jenkins CI update the GitHub comment with all details and apply the filter.
Testing
I was able to test this on the my fork of robottelo here https://github.com/omkarkhatavkar/robottelo/actions/runs/7755989443/job/21152444058