Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail curl command registration #14069

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fail curl command registration #14069

merged 2 commits into from
Mar 5, 2024

Conversation

amolpati30
Copy link
Contributor

Problem Statement

Customer was trying to register client using global registration template and while executing curl command the client was registered but it failed at one point and the echo $? showed exit status as 0.

Solution

Giving status code 0 if passed else 1

Related Issues

@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 14, 2024
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py::test_negative_generate_curl_command_and_fail_registration_intentionally

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5710
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_registration.py::test_negative_generate_curl_command_and_fail_registration_intentionally
Test Result : ================== 3 passed, 40 warnings in 803.25s (0:13:23) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 14, 2024
@amolpati30 amolpati30 self-assigned this Feb 14, 2024
@omkarkhatavkar omkarkhatavkar added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Feb 14, 2024
@amolpati30 amolpati30 force-pushed the fail_curl_command_registration branch 2 times, most recently from baa5220 to aa8cf5f Compare February 14, 2024 09:25
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py::test_negative_generate_curl_command_and_fail_registration_intentionally

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5716
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_registration.py::test_negative_generate_curl_command_and_fail_registration_intentionally
Test Result : ================== 3 passed, 42 warnings in 778.32s (0:12:58) ==================

@amolpati30 amolpati30 marked this pull request as ready for review February 14, 2024 10:33
@amolpati30 amolpati30 requested a review from a team as a code owner February 14, 2024 10:33
shubhamsg199
shubhamsg199 requested changes Feb 14, 2024
View reviewed changes
synkd
synkd reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is failing CI on formatting. Could you please run pre-commit locally and push the changes?

@amolpati30 amolpati30 force-pushed the fail_curl_command_registration branch from f48ebc6 to aa8cf5f Compare February 15, 2024 07:56
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_registration.py::test_negative_generate_curl_command_and_fail_registration_intentionally

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5737
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_registration.py::test_negative_generate_curl_command_and_fail_registration_intentionally
Test Result : ================== 3 passed, 52 warnings in 941.41s (0:15:41) ==================

@amolpati30 amolpati30 marked this pull request as draft February 15, 2024 13:56
@amolpati30 amolpati30 force-pushed the fail_curl_command_registration branch from aa8cf5f to 2978947 Compare February 15, 2024 14:09
@amolpati30 amolpati30 marked this pull request as ready for review February 15, 2024 14:24
lhellebr
lhellebr requested changes Feb 15, 2024
View reviewed changes
shweta83
shweta83 requested changes Feb 16, 2024
View reviewed changes
lhellebr
lhellebr requested changes Feb 21, 2024
View reviewed changes
@amolpati30 amolpati30 force-pushed the fail_curl_command_registration branch 2 times, most recently from 57130cc to b5144c7 Compare February 26, 2024 12:56
@ogajduse
Copy link
Member

@amolpati30 can you please take a look at the failures in the CI/CQ workflow?

@amolpati30 amolpati30 force-pushed the fail_curl_command_registration branch 4 times, most recently from 90769e0 to 42fc33d Compare February 27, 2024 09:30
@amolpati30 amolpati30 force-pushed the fail_curl_command_registration branch from 67f31d5 to 72a6eee Compare February 27, 2024 16:23
@amolpati30 amolpati30 force-pushed the fail_curl_command_registration branch from 72a6eee to 9b76675 Compare February 28, 2024 09:13
@Gauravtalreja1 Gauravtalreja1 added the QETestCoverage Issues and PRs relating to a Satellite bug label Mar 5, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit cc8227d into SatelliteQE:master Mar 5, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@amolpati30 @web-flow
Fail curl command registration (#14069)
e4b194c 
* giving status code as expected for failure test

* giving status code as expected for failure test

(cherry picked from commit cc8227d)
@Satellite-QE Satellite-QE mentioned this pull request Mar 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@amolpati30 @web-flow
Fail curl command registration (#14069)
8a13e9e 
* giving status code as expected for failure test

* giving status code as expected for failure test

(cherry picked from commit cc8227d)
@Satellite-QE Satellite-QE mentioned this pull request Mar 5, 2024
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@amolpati30 @shweta83
Fail curl command registration (SatelliteQE#14069)
94ca26c 
* giving status code as expected for failure test

* giving status code as expected for failure test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synkd synkd synkd left review comments

@ogajduse ogajduse ogajduse approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@shweta83 shweta83 Awaiting requested review from shweta83

@shubhamsg199 shubhamsg199 Awaiting requested review from shubhamsg199

@lhellebr lhellebr Awaiting requested review from lhellebr

Assignees

@amolpati30 amolpati30

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR QETestCoverage Issues and PRs relating to a Satellite bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@amolpati30 @Satellite-QE @ogajduse @lhellebr @Gauravtalreja1 @shweta83 @synkd @shubhamsg199 @omkarkhatavkar