Fix useless asserts in installer tests

[rmynar]

Fixing assertions that were always True and therefore useless.

Note: bool("any string with non-zero length") is True, True or False is True

[rmynar]

trigger: test-robottelo
pytest: tests/foreman/ -k 'test_installer_sat_pub_directory_accessibility or test_installer_cap_pub_directory_accessibility'

[ogajduse]

Good catch @rmynar! I have prepared a patch that adds flake8-simplify and flake8-return rulesets to our ruff linter config some time ago and seeing your patch made me publish it today. #14100

Let's merge yours first and I will rebase mine.

[ogajduse]

@rmynar Can you please take a look at the PRT failures?

[rmynar]

trigger: test-robottelo
pytest: tests/foreman/ -k "test_installer_sat_pub_directory_accessibility or test_installer_cap_pub_directory_accessibility"

[JacobCallahan]

Some minor recommendations

[JacobCallahan]

If you're just checking for specific substrings, you likely don't need to bother splitting the output into a list.

Suggested change

	accessibility_check = target_sat.execute(command).stdout.split('\r\n')
	assert 'HTTP/1.1 200 OK' in accessibility_check or 'HTTP/2 200 ' in accessibility_check
	accessibility_check = target_sat.execute(command).stdout
	assert 'HTTP/1.1 200 OK' in accessibility_check or 'HTTP/2 200 ' in accessibility_check

[JacobCallahan]

Same recommendation here

Suggested change

	accessibility_check = target_sat.execute(command).stdout.split('\r\n')
	assert 'HTTP/1.1 200 OK' not in accessibility_check
	assert 'HTTP/2 200 ' not in accessibility_check
	accessibility_check = target_sat.execute(command).stdout
	assert 'HTTP/1.1 200 OK' not in accessibility_check
	assert 'HTTP/2 200 ' not in accessibility_check

[JacobCallahan]

You get the idea

Suggested change

	accessibility_check = capsule_configured.execute(command).stdout.split('\r\n')
	assert 'HTTP/1.1 200 OK' in accessibility_check or 'HTTP/2 200 ' in accessibility_check
	accessibility_check = capsule_configured.execute(command).stdout
	assert 'HTTP/1.1 200 OK' in accessibility_check or 'HTTP/2 200 ' in accessibility_check

[JacobCallahan]

Same

Suggested change

	accessibility_check = capsule_configured.execute(command).stdout.split('\r\n')
	assert 'HTTP/1.1 200 OK' not in accessibility_check
	assert 'HTTP/2 200 ' not in accessibility_check
	accessibility_check = capsule_configured.execute(command).stdout
	assert 'HTTP/1.1 200 OK' not in accessibility_check
	assert 'HTTP/2 200 ' not in accessibility_check

[ogajduse]

trigger: test-robottelo
pytest: tests/foreman/destructive/test_installer.py::test_installer_sat_pub_directory_accessibility tests/foreman/installer/test_installer.py::test_installer_cap_pub_directory_accessibility

[Satellite-QE]

PRT Result

Build Number: 5780
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_installer.py::test_installer_sat_pub_directory_accessibility tests/foreman/installer/test_installer.py::test_installer_cap_pub_directory_accessibility
Test Result : ================= 2 passed, 114 warnings in 2647.34s (0:44:07) =================

[lhellebr]

I agree with Jacob, otherwise LGTM

[rmynar]

I just wanted to fix the logical error in assertion, but you're right that the split was useless. Hopefully it looks better now

[JacobCallahan]

ACK, thanks for the adjustment!