Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8-simplify and flake8-return to ruff config #14100

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add flake8-simplify and flake8-return to ruff config #14100

merged 1 commit into from
Mar 7, 2024

Conversation

ogajduse
Copy link
Member

This PR adds two new rulesets - flake8-simplify and flake8-return.

@ogajduse ogajduse added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 16, 2024
@ogajduse ogajduse self-assigned this Feb 16, 2024
@ogajduse ogajduse mentioned this pull request Feb 16, 2024
Merged
@ogajduse ogajduse marked this pull request as ready for review February 20, 2024 16:33
@ogajduse ogajduse requested review from a team as code owners February 20, 2024 16:33
@omkarkhatavkar
Copy link

trigger: test-robottelo

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5820
Build Status: UNSTABLE
PRT Comment: pytest null
Test Result : =========================== short test summary info ============================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 22, 2024
@ogajduse
Copy link
Member Author

PRT failure is unrelated to the changes in this PR:
AttributeError: 'bytes' object has no attribute 'content'

lhellebr
lhellebr approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously I haven't checked all the automatically made changes but including these rulesets lgtm.

@ogajduse
Copy link
Member Author

Due to long wait time, the conflict in robottelo/cli/hammer.py must be resolved.

@lpramuk lpramuk merged commit db19610 into SatelliteQE:master Mar 7, 2024
6 checks passed
This was referenced Mar 7, 2024
Closed
Closed
Closed
Closed
@ogajduse ogajduse deleted the lint/ruff/sim-ret branch March 7, 2024 22:30
ogajduse added a commit to ogajduse/robottelo that referenced this pull request Mar 11, 2024
@ogajduse
Add flake8-simplify and flake8-return to ruff config (SatelliteQE#14100)
a73319f 
(cherry picked from commit db19610)
ogajduse added a commit to ogajduse/robottelo that referenced this pull request Mar 11, 2024
@ogajduse
Add flake8-simplify and flake8-return to ruff config (SatelliteQE#14100)
aedf430 
(cherry picked from commit db19610)
ogajduse added a commit to ogajduse/robottelo that referenced this pull request Mar 11, 2024
@ogajduse
Add flake8-simplify and flake8-return to ruff config (SatelliteQE#14100)
1c3a2fc 
(cherry picked from commit db19610)
ogajduse added a commit to ogajduse/robottelo that referenced this pull request Mar 11, 2024
@ogajduse
Add flake8-simplify and flake8-return to ruff config (SatelliteQE#14100)
abd5075 
(cherry picked from commit db19610)
ogajduse added a commit to ogajduse/robottelo that referenced this pull request Mar 11, 2024
@ogajduse
Add flake8-simplify and flake8-return to ruff config (SatelliteQE#14100)
128d6fb 
(cherry picked from commit db19610)
This was referenced Mar 11, 2024
Merged
Merged
Merged
Merged
lhellebr pushed a commit that referenced this pull request Mar 12, 2024
@ogajduse @omkarkhatavkar
[6.15.z] Add flake8-simplify and flake8-return to ruff config (#14100) (
425c2b6 
#14342)

* Add flake8-simplify and flake8-return to ruff config (#14100)

(cherry picked from commit db19610)

* fixed sanity suite, AttributeError due to not matching scope (#14309)

(cherry picked from commit 063ac02)

---------

Co-authored-by: Omkar Khatavkar <[email protected]>
lhellebr pushed a commit that referenced this pull request Mar 12, 2024
@ogajduse @omkarkhatavkar
[6.14.z] Add flake8-simplify and flake8-return to ruff config (#14100) (
0ce7303 
#14341)

* Add flake8-simplify and flake8-return to ruff config (#14100)

(cherry picked from commit db19610)

* fixed sanity suite, AttributeError due to not matching scope (#14309)

(cherry picked from commit 063ac02)

---------

Co-authored-by: Omkar Khatavkar <[email protected]>
lhellebr pushed a commit that referenced this pull request Mar 12, 2024
@ogajduse @omkarkhatavkar
[6.13.z] Add flake8-simplify and flake8-return to ruff config (#14100) (
a0951b9 
#14340)

* Add flake8-simplify and flake8-return to ruff config (#14100)

(cherry picked from commit db19610)

* fixed sanity suite, AttributeError due to not matching scope (#14309)

(cherry picked from commit 063ac02)

---------

Co-authored-by: Omkar Khatavkar <[email protected]>
lhellebr pushed a commit that referenced this pull request Mar 12, 2024
@ogajduse
[6.12.z] Add flake8-simplify and flake8-return to ruff config (#14100) (
11f1616 
#14339)

Add flake8-simplify and flake8-return to ruff config (#14100)

(cherry picked from commit db19610)
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@ogajduse @shweta83
Add flake8-simplify and flake8-return to ruff config (SatelliteQE#14100)
643f196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 left review comments

@jyejare jyejare jyejare left review comments

@lpramuk lpramuk lpramuk approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@ogajduse ogajduse

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ogajduse @omkarkhatavkar @Satellite-QE @lhellebr @lpramuk @jyejare @jameerpathan111 @LadislavVasina1