Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server_config in subscription test #14226

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix server_config in subscription test #14226

merged 1 commit into from
Mar 1, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Feb 29, 2024

Problem Statement

During z-stream sign-off I noticed that api/test_subscription.py/test_positive_delete_manifest_as_another_user is failing with

E   TypeError: Subscription.init() got multiple values for argument 'server_config'

since this entities refactor.

Solution

Pass the server_config as named parameter.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py -k delete_manifest_as_another_user

@vsedmik vsedmik added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Feb 29, 2024
@vsedmik vsedmik self-assigned this Feb 29, 2024
@vsedmik vsedmik requested a review from a team as a code owner February 29, 2024 12:40
@vsedmik
Copy link
Contributor Author

vsedmik commented Feb 29, 2024

trigger: test-robottelo
pytest: tests/foreman/api/test_subscription.py -k delete_manifest_as_another_user

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 5901
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_subscription.py -k delete_manifest_as_another_user --external-logging
Test Result : ========== 1 passed, 17 deselected, 11 warnings in 717.50s (0:11:57) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 29, 2024
@pondrejk pondrejk merged commit 3ebc7c8 into SatelliteQE:master Mar 1, 2024
15 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 1, 2024
@vsedmik @web-flow
Fix server_config in subscription test (#14226)
0600c38 
(cherry picked from commit 3ebc7c8)
@Satellite-QE Satellite-QE mentioned this pull request Mar 1, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Mar 1, 2024
@vsedmik @web-flow
Fix server_config in subscription test (#14226)
1fb2a11 
(cherry picked from commit 3ebc7c8)
github-actions bot pushed a commit that referenced this pull request Mar 1, 2024
@vsedmik @web-flow
Fix server_config in subscription test (#14226)
53160a9 
(cherry picked from commit 3ebc7c8)
This was referenced Mar 1, 2024
Closed
Merged
Merged
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@vsedmik @shweta83
Fix server_config in subscription test (SatelliteQE#14226)
80c8151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsedmik @Satellite-QE @pondrejk @ColeHiggins2