Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert commands results. Remove CA download, machines already have it. Do not install a library through pip. #14511

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Assert commands results. Remove CA download, machines already have it. Do not install a library through pip. #14511

merged 5 commits into from
Apr 26, 2024

Conversation

lhellebr
Copy link
Contributor

No description provided.

@lhellebr lhellebr requested a review from a team as a code owner March 25, 2024 13:34
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout

@lhellebr lhellebr added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing labels Mar 25, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6181
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout --external-logging
Test Result : ================== 1 failed, 1 warning in 2945.33s (0:49:05) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 25, 2024
@lhellebr
Copy link
Contributor Author

Test's setup passed and it failed later. Doesn't seem like this PR's fault. I tested on 6.15 without issues, I'll test on stream and comment the results.

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6190
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout --external-logging
Test Result : ================== 1 failed, 1 warning in 2986.14s (0:49:46) ===================

@lhellebr lhellebr requested a review from a team as a code owner March 26, 2024 12:25
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 26, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6204
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout --external-logging
Test Result : ================== 1 failed, 1 warning in 2988.45s (0:49:48) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 26, 2024
@lhellebr lhellebr force-pushed the bz_2271398_keycloak_client_dependency branch from f7530c6 to f02b15e Compare March 26, 2024 15:30
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Mar 26, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6212
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout --external-logging
Test Result : ================== 1 passed, 1 warning in 2945.55s (0:49:05) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 26, 2024
@lhellebr
Copy link
Contributor Author

lhellebr commented Apr 2, 2024

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 2, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6268
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout --external-logging
Test Result : ================== 1 passed, 4 warnings in 2602.95s (0:43:22) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 2, 2024
@lhellebr
Copy link
Contributor Author

lhellebr commented Apr 3, 2024

@SatelliteQE/robottelo-tier-1-reviewers

This was referenced Apr 5, 2024
Merged
Merged
@lhellebr
Copy link
Contributor Author

lhellebr commented Apr 5, 2024

@SatelliteQE/robottelo-tier-2-reviewers

shweta83
shweta83 requested changes Apr 8, 2024
View reviewed changes
pytest_fixtures/component/satellite_auth.py Outdated
--app-name foreman-openidc \
--keycloak-server-url {settings.rhsso.host_url} \
--keycloak-admin-username "admin" \
--keycloak-realm "{settings.rhsso.realm}" \
--keycloak-admin-realm master \
--keycloak-auth-role root-admin -t openidc -l /users/extlogin --force'
).status
== 0
)
if is_open('BZ:2113905'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition can be removed as this BZ is verfied and closed now.

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 23, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6646
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout --external-logging
Test Result : ================== 12 warnings, 1 error in 1561.60s (0:26:01) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 23, 2024
@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout

@lhellebr
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout

@lhellebr
Copy link
Contributor Author

BZ has been converted to docs, lxml package now should be installed manually according to docs. Updating accordingly.

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6711
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_ldap_authentication.py::test_session_expire_rhsso_idle_timeout --external-logging
Test Result : ================= 1 passed, 17 warnings in 2393.81s (0:39:53) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 26, 2024
@ogajduse
Copy link
Member

PRT is passing, and Shweta's comment was addressed. Merging.

@ogajduse ogajduse merged commit c9af98b into SatelliteQE:master Apr 26, 2024
10 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@lhellebr @web-flow
Assert commands results. Remove CA download, machines already have it…
a84b6c0 
…. Do not install a library through pip. (#14511)

(cherry picked from commit c9af98b)
@Satellite-QE Satellite-QE mentioned this pull request Apr 26, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@lhellebr @jyejare
Assert commands results. Remove CA download, machines already have it…
5c8234f 
…. Do not install a library through pip. (SatelliteQE#14511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shweta83 shweta83 shweta83 requested changes

@ogajduse ogajduse ogajduse approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@lhellebr lhellebr

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lhellebr @Satellite-QE @ogajduse @pondrejk @shweta83