Add case for special chars in HTTP proxy password #14538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
CherryPick
|
trigger: test-robottelo |
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
pondrejk
approved these changes
Mar 27, 2024
Griffin-Sullivan
approved these changes
Mar 28, 2024
| """Class representing HTTP Proxy host""" | ||
|
|
||
| def __init__(self, url, **kwargs): | ||
| self._conf_dir = '/etc/squid/' |
There was a problem hiding this comment.
Suggested change
| self._conf_dir = '/etc/squid/' | |
| self._conf_dir = '/etc/squid' |
Strings below would look better if you did this and then called f'{self._conf_dir}/passwd'
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit 85dd8bc)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit 85dd8bc)
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
We are missing coverage for a BZ where the HTTP proxy is created with a user containing special characters in his password.
Solution
Not only we need to create the proxy at the Satellite side, we also need to create the user at the proxy side to verify the content operations actually work. In the end I decided to create such users dynamically during the test run, so I needed to add a new
ProxyHostclass with a few functions to handle that. The class is instantiated in a session-scoped fixture and used in test and other fixture.PRT test Cases example
trigger: test-robottelo
pytest: tests/foreman/ui/test_http_proxy.py -k special