Make default_os name and major versions configurable

[dosas]

Problem Statement

default os is hardcoded in fixture

Solution

• make default os configurable

Related Question

Why is a new instance of OperatingSystem created here instead of returning the one create above?

Related test

tests/foreman/ui/test_registration.py::test_global_registration_form_populate

[Griffin-Sullivan]

Looks good to me. Let's run PRT and see how it goes.

[Griffin-Sullivan]

Why is a new instance of OperatingSystem created here instead of returning the one create above?

My assumption would be to make sure the os variable is updated with a final GET before we return it. Might not be necessary, but it's not a bad practice IMO.

[Griffin-Sullivan]

trigger: test-robottelo
pytest: tests/foreman/ui/test_registration.py::test_global_registration_form_populate

[Satellite-QE]

PRT Result

Build Number: 6359
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_registration.py::test_global_registration_form_populate --external-logging
Test Result : ================== 1 passed, 6 warnings in 843.05s (0:14:03) ===================

[lpramuk]

We need to find better place for DEFAULT_OS setting than in server.yaml (relates to Satellite server)

[lpramuk]

We need to find better place for DEFAULT_OS setting than in server.yaml (relates to Satellite server)

[ogajduse]

I have traced the origin of the fixture back to d1cce26 (#7604).

Can we rework the fixture to create Operating Systems instead of creating new ones? If not, can we create a new fixture that would create new OSes instead of searching for existing ones? Eventually, this fixture can stay if there are tests that need to search for existing OSes.

[dosas]

I have traced the origin of the fixture back to d1cce26 (#7604).

Can we rework the fixture to create Operating Systems instead of creating new ones?
If not, can we create a new fixture that would create new OSes instead of searching for existing ones?

IMO this is out of scope for this PR

Eventually, this fixture can stay if there are tests that need to search for existing OSes.

As I understand it this fixture is used to search for operating systems that have been setup by the foreman installer?

[rplevka]

What I am worried about is that this fixture is very misleading.
I'd expect it to return just 1 OS entity - the one that was created on Satellite/Foreman installation - that is the representation of the OS the satellite is running on.
It is used by satellite host entity. Now this could be done by navigating to the hosts, accessing the satellite host entity and read out its OS.

Even better, this could be directly accessed through sat object returned by target_sat fixture (target_sat.nailgun_host.operatingsystem).
I'd probably rewrite this fixture to a oneliner:

@pytest.fixture(scope='session')
def default_os(session_target_sat):
    return session_target_sat.nailgun_host.operatingsystem

[Griffin-Sullivan]

It seems this has gathered a lot of attention. While I agree with @rplevka's opinion that this fixture is misleading, the original intent of this PR was to keep the same functionality of default_os, but make it more flexible for passing in other OSes. I think for now we could leave this as is, and in a separate PR discuss @rplevka's idea and possibly rename / add a better description to the current fixture to be more obvious.

[Griffin-Sullivan]

trigger: test-robottelo
pytest: tests/foreman/ui/test_registration.py::test_global_registration_form_populate

[Satellite-QE]

PRT Result

Build Number: 6464
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_registration.py::test_global_registration_form_populate --external-logging
Test Result : =================== 8 warnings, 1 error in 720.53s (0:12:00) ===================

[Satellite-QE]

PRT Result

Build Number: 6531
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_registration.py::test_global_registration_form_populate --external-logging
Test Result : ================== 1 failed, 9 warnings in 1284.46s (0:21:24) ==================

[ogajduse]

It seems that our Selenium grid is down ATM.

selenium.common.exceptions.SessionNotCreatedException: Message: Could not start a new session. New session request timed out 

Let's try different test

[ogajduse]

trigger: test-robottelo
pytest: tests/foreman/api/test_architecture.py::test_positive_CRUD

[Satellite-QE]

PRT Result

Build Number: 6533
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_architecture.py::test_positive_CRUD --external-logging
Test Result : ================== 1 passed, 9 warnings in 657.96s (0:10:57) ===================

[jyejare]

@ogajduse I will be merging this as @dosas has been waiting for it for a long. We will discuss and implement the dynamic approach sometimes in this quarter.

[jyejare]

trigger: test-robottelo
pytest: tests/foreman/api/test_architecture.py::test_positive_CRUD

[dosas]

@jyejare I rebased

[jyejare]

trigger: test-robottelo
pytest: tests/foreman/api/test_architecture.py::test_positive_CRUD

[Satellite-QE]

PRT Result

Build Number: 6799
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_architecture.py::test_positive_CRUD --external-logging
Test Result : ================== 1 passed, 9 warnings in 757.00s (0:12:37) ===================