Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT-23362-update-fixture-as-per-new-feature(6.16) #14673

Conversation

vijaysawant
Copy link
Contributor

@vijaysawant vijaysawant commented Apr 8, 2024

Problem Statement

[1] Component Audit: SAT-23362
test_positive_delete_rhel_repo
test_positive_sync_repo_null_contents_changed
test_positive_sync_kickstart_check_os
test_positive_recreate_pulp_repositories
test_positive_sync_rh_repos
6.16 satellite doesn't support sca disable org, because tests were using fixture *_entitlement_manifest_org

[2] During TFA, found test test_positive_delete_rhel_repo was failing due to airgun issue
Error - IndexError: list index out of range This was due to wrong search box and search button

[3] During TFA, found test test_positive_sync_kickstart_check_os was failing due to keyError KeyError: 'rhel8 + "_bos"'

Solution

[1] Update fixture, this solution is only applicable to stream version of satellite.

[2] Update airgun view and entities, PR mentioned in Related Issues section and applicable for new UI 6.15.Z and Stream

[3] Changed robottelo constants key for REPOSET>kickstart>distro from
rhel8 to rhel8_bos
rhel9 to rhel9_bos
Link robottelo/constants/init.py

Related Issues

Airgun PR: SatelliteQE/airgun#1315 (Merged)

@vijaysawant vijaysawant added TestFailure Issues and PRs related to a test failing in automation Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Apr 8, 2024
@vijaysawant vijaysawant requested a review from a team as a code owner April 8, 2024 11:03
@vijaysawant
Copy link
Contributor Author

vijaysawant commented Apr 8, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_repository.py -k 'test_positive_delete_rhel_repo'
airgun: 1315

@vijaysawant vijaysawant force-pushed the stream_small_fix_for_sca_only_feature branch from f31f2e6 to ad18bcb Compare April 8, 2024 11:50
@vijaysawant vijaysawant marked this pull request as draft April 8, 2024 11:51
@vijaysawant vijaysawant changed the title SAT-23362-test_positive_delete_rhel_repo(6.16) SAT-23362-update-fixture-as-per-new-feature(6.16) Apr 8, 2024
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6351
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_repository.py -k test_positive_delete_rhel_repo --external-logging
Test Result : ========== 1 failed, 32 deselected, 5 warnings in 4386.00s (1:13:06) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 8, 2024
@vijaysawant
Copy link
Contributor Author

Robottelo-pr-testing
Error message:
wait_for.TimedOutError: Could not do 'lambda defined as `lambda: all(node.progress is None for node in repo_nodes),`' at /opt/app-root/lib64/python3.11/site-packages/airgun/entities/sync_status.py:42 in time

It's not related to current change.

@vijaysawant

This comment was marked as duplicate.

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k 'test_positive_sync_repo_null_contents_changed'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6355
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py -k test_positive_sync_repo_null_contents_changed --external-logging
Test Result : ========== 1 passed, 164 deselected, 4 warnings in 695.54s (0:11:35) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 8, 2024
@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Apr 8, 2024
@Satellite-QE

This comment was marked as duplicate.

@vijaysawant

This comment was marked as duplicate.

@Satellite-QE

This comment was marked as duplicate.

@SatelliteQE SatelliteQE deleted a comment from Satellite-QE Apr 9, 2024
@Satellite-QE

This comment was marked as duplicate.

@Satellite-QE Satellite-QE removed the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 9, 2024
@vijaysawant vijaysawant force-pushed the stream_small_fix_for_sca_only_feature branch from 075013f to ab37a93 Compare April 9, 2024 12:27
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6390
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py -k test_positive_sync_kickstart_check_os --external-logging
Test Result : ========== 4 passed, 161 deselected, 76 warnings in 923.70s (0:15:23) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 9, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k 'test_positive_recreate_pulp_repositories'

@vijaysawant vijaysawant force-pushed the stream_small_fix_for_sca_only_feature branch from ab37a93 to d04f5b6 Compare April 9, 2024 12:51
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 9, 2024
@Satellite-QE

This comment was marked as duplicate.

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 9, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_repository.py -k 'test_positive_recreate_pulp_repositories'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6395
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_repository.py -k test_positive_recreate_pulp_repositories --external-logging
Test Result : ========== 1 passed, 164 deselected, 4 warnings in 749.10s (0:12:29) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 9, 2024
@vijaysawant vijaysawant marked this pull request as ready for review April 9, 2024 13:24
@vijaysawant vijaysawant requested a review from a team as a code owner April 9, 2024 13:24
@omkarkhatavkar
Copy link

@vijaysawant Did you missed this code to update https://github.com/SatelliteQE/robottelo/blob/master/tests/foreman/cli/test_repositories.py#L119 ?

@vijaysawant
Copy link
Contributor Author

@vijaysawant Did you missed this code to update https://github.com/SatelliteQE/robottelo/blob/master/tests/foreman/cli/test_repositories.py#L119 ?

Yes, as the constants value updated then corresponding keys need to be updated.
Do you see any other test which need to be updated with this keyname? @omkarkhatavkar

@vijaysawant vijaysawant force-pushed the stream_small_fix_for_sca_only_feature branch from d04f5b6 to 75cd151 Compare April 10, 2024 07:43
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 10, 2024
@omkarkhatavkar
Copy link

@vijaysawant try to run tests that use kickstart from reposet.

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_positive_disable_rh_repo_with_basearch'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6411
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_repositories.py -k test_positive_disable_rh_repo_with_basearch --external-logging
Test Result : =========== 4 deselected, 12 warnings, 1 error in 653.26s (0:10:53) ============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 10, 2024
@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_repositories.py -k 'test_positive_disable_rh_repo_with_basearch'
env:
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.15'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '13.0'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6412
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_repositories.py -k test_positive_disable_rh_repo_with_basearch --external-logging
Test Result : =========== 1 passed, 4 deselected, 13 warnings in 755.92s (0:12:35) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 10, 2024
@omkarkhatavkar omkarkhatavkar merged commit f8fe6b8 into SatelliteQE:master Apr 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Fix :) Easiest Fix to review and quick merge request. No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants