-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safely bump ruff-pre-commit to v0.3.0 #14692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Catch @lpramuk , BTW interesting why pre-commit updater did not find this older version and did not tried to update it to latest.
@jyejare Can you expand on what |
@@ -13,7 +13,7 @@ repos: | |||
hooks: | |||
- id: black | |||
- repo: https://github.com/astral-sh/ruff-pre-commit | |||
rev: v0.0.277 | |||
rev: v0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update it to latest available release? https://github.com/astral-sh/ruff-pre-commit/releases
rev: v0.3.0 | |
rev: v0.3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we can't - $SUBJ
says Safely bump ruff-pre-commit ....
@jyejare @rmynar We haven't updated the pre-commit hooks in a while, and @ogajduse has issue created for it #12650 |
@ogajduse @Gauravtalreja1 I was in impression that BTW I dont see any blocker adding pre-commit-ci in robottelo now. Do you see any @ogajduse ? |
@jyejare No blockers from my PoV. I can take it up. |
(cherry picked from commit 590e175)
(cherry picked from commit 590e175)
(cherry picked from commit 590e175)
Problem Statement
ruff-pre-commit v0.0.277 is almost 1year old and I experienced some sort of module imports re-order hell with this version.
Solution
Safely bump ruff-pre-commit to < 0.3.1 (no breaking changes)
Related Issues