Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely bump ruff-pre-commit to v0.3.0 #14692

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

lpramuk
Copy link
Contributor

@lpramuk lpramuk commented Apr 9, 2024

Problem Statement

ruff-pre-commit v0.0.277 is almost 1year old and I experienced some sort of module imports re-order hell with this version.

Solution

Safely bump ruff-pre-commit to < 0.3.1 (no breaking changes)

Related Issues

@lpramuk lpramuk added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 9, 2024
@lpramuk lpramuk self-assigned this Apr 9, 2024
@lpramuk lpramuk requested a review from a team as a code owner April 9, 2024 10:52
@lpramuk lpramuk requested review from ogajduse and rmynar April 9, 2024 10:52
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Catch @lpramuk , BTW interesting why pre-commit updater did not find this older version and did not tried to update it to latest.

@ogajduse
Copy link
Member

ogajduse commented Apr 9, 2024

@jyejare Can you expand on what pre-commit updater is and point me to a code where we have it configured for this repository?

@@ -13,7 +13,7 @@ repos:
hooks:
- id: black
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.0.277
rev: v0.3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update it to latest available release? https://github.com/astral-sh/ruff-pre-commit/releases

Suggested change
rev: v0.3.0
rev: v0.3.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we can't - $SUBJ says Safely bump ruff-pre-commit ....

@Gauravtalreja1
Copy link
Collaborator

@jyejare @rmynar We haven't updated the pre-commit hooks in a while, and @ogajduse has issue created for it #12650
We can either use pre-commit-ci to bump this pre-commit hooks which we've enabled in Airgun/Nailgun repos, or we can do it manually using pre-commit autoupdate; pre-commit run --all-files

@jyejare
Copy link
Member

jyejare commented Apr 9, 2024

@ogajduse @Gauravtalreja1 I was in impression that pre-commit-ci(AutoUpdater) is enabled in Robottelo and hence the comment feeling amused.

BTW I dont see any blocker adding pre-commit-ci in robottelo now. Do you see any @ogajduse ?

@ogajduse
Copy link
Member

ogajduse commented Apr 9, 2024

@jyejare No blockers from my PoV. I can take it up.

@ogajduse ogajduse merged commit 590e175 into SatelliteQE:master Apr 9, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
lpramuk added a commit to lpramuk/robottelo that referenced this pull request Apr 10, 2024
lpramuk added a commit to lpramuk/robottelo that referenced this pull request Apr 10, 2024
Gauravtalreja1 pushed a commit that referenced this pull request Apr 10, 2024
Safely bump ruff-pre-commit to v0.3.0 (#14692)

(cherry picked from commit 590e175)
Gauravtalreja1 pushed a commit that referenced this pull request Apr 10, 2024
Safely bump ruff-pre-commit to v0.3.0 (#14692)

(cherry picked from commit 590e175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants