Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper teardown of VMware client #14799

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add proper teardown of VMware client #14799

merged 1 commit into from
Apr 23, 2024

Conversation

shubhamsg199
Copy link
Contributor

@shubhamsg199 shubhamsg199 commented Apr 17, 2024 •
edited
Loading

Problem Statement

There wasn't any proper teardown of vmwareclient. we see DEBUG - vCenter keep-alive: 2024-04-14 07:51:45.515419+00:00 in the logs

Solution

Add a fixture which handles the proper teardown

@shubhamsg199 shubhamsg199 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Apr 17, 2024
@shubhamsg199 shubhamsg199 self-assigned this Apr 17, 2024
@shubhamsg199 shubhamsg199 requested review from a team as code owners April 17, 2024 08:07
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6547
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end --external-logging
Test Result : ========== 2 failed, 10 deselected, 57 warnings in 2043.05s (0:34:03) ==========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Apr 17, 2024
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6550
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_computeresource_vmware.py -k test_positive_vmware_custom_profile_end_to_end --external-logging
Test Result : ========== 2 passed, 10 deselected, 71 warnings in 8832.15s (2:27:12) ==========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Apr 17, 2024
@shubhamsg199 shubhamsg199 force-pushed the vmware_disconnect branch 2 times, most recently from 9c7e73a to ad642c3 Compare April 22, 2024 11:17
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Apr 22, 2024
@shubhamsg199 shubhamsg199 added the 6.13.z Introduced in or relating directly to Satellite 6.13 label Apr 22, 2024
@shubhamsg199
Proper teardown of VMwar client
eaaf9a2 
Signed-off-by: Shubham Ganar <[email protected]>
@pondrejk pondrejk merged commit 9de3979 into SatelliteQE:master Apr 23, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
@shubhamsg199 @web-flow
Add proper teardown of VMware client (#14799)
9349023 
Proper teardown of VMwar client

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 9de3979)
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
@shubhamsg199 @web-flow
Add proper teardown of VMware client (#14799)
c611128 
Proper teardown of VMwar client

Signed-off-by: Shubham Ganar <[email protected]>
(cherry picked from commit 9de3979)
This was referenced Apr 23, 2024
Merged
Merged
Closed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shubhamsg199 @jyejare
Add proper teardown of VMware client (SatelliteQE#14799)
32d7bdf 
Proper teardown of VMwar client

Signed-off-by: Shubham Ganar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@jyejare jyejare jyejare approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@shweta83 shweta83 shweta83 approved these changes

@synkd synkd synkd approved these changes

@Gauravtalreja1 Gauravtalreja1 Awaiting requested review from Gauravtalreja1

Assignees

@shubhamsg199 shubhamsg199

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shubhamsg199 @Satellite-QE @pondrejk @jyejare @jameerpathan111 @Gauravtalreja1 @shweta83 @synkd