Remove nailgun.entities imports in pytest_fixtures

[tpapaioa]

Problem Statement

SAT-22530

Uses of nailgun.entities.${ENTITY} should be replaced with ${SATELLITE_INSTANCE}.api.${ENTITY}.

Solution

All fixtures under pytest_fixtures/ now use nailgun through the satellite instance's api attribute, and imports of nailgun.entities have been removed.

Test results are the same before and after these changes.

with PR changes:

PRT job #6979:

18:53:58  =========================== short test summary info ============================
18:53:58  FAILED tests/foreman/api/test_host.py::test_positive_create_and_update_with_user [...]
18:53:58  FAILED tests/foreman/ui/test_ldap_authentication.py::test_verify_group_permissions [...]
18:53:58  ERROR tests/foreman/api/test_oscappolicy.py::TestOscapPolicy::test_positive_crud_scap_policy [...]
18:53:58  = 2 failed, 13 passed, 1 skipped, 617 warnings, 1 error in 3674.62s (1:01:14) ==

master:

PRT job #6996:

16:30:58  =========================== short test summary info ============================
16:30:58  FAILED tests/foreman/api/test_host.py::test_positive_create_and_update_with_user [...]
16:30:58  FAILED tests/foreman/ui/test_ldap_authentication.py::test_verify_group_permissions [...]
16:30:58  ERROR tests/foreman/api/test_oscappolicy.py::TestOscapPolicy::test_positive_crud_scap_policy [...]
16:30:58  = 2 failed, 13 passed, 1 skipped, 610 warnings, 1 error in 3667.19s (1:01:07) ==

Related Issues

[tpapaioa]

trigger: test-robottelo
pytest:  tests/foreman/api/test_discoveryrule.py::test_positive_end_to_end_crud tests/foreman/api/test_host.py::test_negative_update_name tests/foreman/api/test_host.py::test_positive_create_and_update_os tests/foreman/api/test_host.py::test_positive_create_and_update_with_compute_profile tests/foreman/api/test_host.py::test_positive_create_and_update_with_model tests/foreman/api/test_host.py::test_positive_create_and_update_with_subnet tests/foreman/api/test_host.py::test_positive_create_and_update_with_user tests/foreman/api/test_oscappolicy.py::TestOscapPolicy::test_positive_crud_scap_policy tests/foreman/cli/test_contentview.py::TestContentView::test_positive_update_filter tests/foreman/cli/test_discoveryrule.py::TestDiscoveryRule::test_positive_create_disabled_rule tests/foreman/destructive/test_ldap_authentication.py::test_positive_autonegotiate[IDM] tests/foreman/ui/test_bookmarks.py::test_positive_create_bookmark_public[ActivationKey] tests/foreman/ui/test_host.py::test_positive_check_permissions_affect_create_procedure tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource tests/foreman/ui/test_ldap_authentication.py::test_verify_group_permissions tests/foreman/ui/test_registration.py::test_positive_global_registration_form tests/foreman/ui/test_repository.py::test_positive_remove_credentials

[Satellite-QE]

PRT Result

Build Number: 6979
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveryrule.py::test_positive_end_to_end_crud tests/foreman/api/test_host.py::test_negative_update_name tests/foreman/api/test_host.py::test_positive_create_and_update_os tests/foreman/api/test_host.py::test_positive_create_and_update_with_compute_profile tests/foreman/api/test_host.py::test_positive_create_and_update_with_model tests/foreman/api/test_host.py::test_positive_create_and_update_with_subnet tests/foreman/api/test_host.py::test_positive_create_and_update_with_user tests/foreman/api/test_oscappolicy.py::TestOscapPolicy::test_positive_crud_scap_policy tests/foreman/cli/test_contentview.py::TestContentView::test_positive_update_filter tests/foreman/cli/test_discoveryrule.py::TestDiscoveryRule::test_positive_create_disabled_rule tests/foreman/destructive/test_ldap_authentication.py::test_positive_autonegotiate[IDM] tests/foreman/ui/test_bookmarks.py::test_positive_create_bookmark_public[ActivationKey] tests/foreman/ui/test_host.py::test_positive_check_permissions_affect_create_procedure tests/foreman/ui/test_ldap_authentication.py::test_positive_group_sync_open_ldap_authsource tests/foreman/ui/test_ldap_authentication.py::test_verify_group_permissions tests/foreman/ui/test_registration.py::test_positive_global_registration_form tests/foreman/ui/test_repository.py::test_positive_remove_credentials --external-logging
Test Result : = 2 failed, 13 passed, 1 skipped, 617 warnings, 1 error in 3674.62s (1:01:14) ==

[JacobCallahan]

ACK on the changes. Can you determine (or get with the component owners) if the failures in PRT are related?

[omkarkhatavkar]

@JacobCallahan @tpapaioa I dont see these failures related to this PR. I see some failures because of removing the nailgun entities. These are need to modified by the component owner.

[tpapaioa]

ACK on the changes. Can you determine (or get with the component owners) if the failures in PRT are related?

@JacobCallahan The PRT test failures / errors are the same before and after these changes, and are unrelated, pre-existing issues.