Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to use fixed mask #15091

Merged
merged 1 commit into from
May 17, 2024
Merged

Update tests to use fixed mask #15091

merged 1 commit into from
May 17, 2024

Conversation

shweta83
Copy link
Contributor

Problem Statement

Earlier subnet used fixed mask but it was changed to generate random mask in #13284 which was causing test failures with Start of IP range does not belong to subnet\n End of IP range does not belong to subnet

Solution

To resolve the issue, I am reverting the change in the module.

Related Issues

@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 17, 2024
@shweta83 shweta83 self-assigned this May 17, 2024
@shweta83 shweta83 requested a review from a team as a code owner May 17, 2024 05:11
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subnet.py

@shweta83 shweta83 requested a review from Gauravtalreja1 May 17, 2024 05:12
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6980
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subnet.py --external-logging
Test Result : ========== 21 passed, 18 deselected, 90 warnings in 954.91s (0:15:54) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 17, 2024
@Gauravtalreja1 Gauravtalreja1 added the Easy Fix :) Easiest Fix to review and quick merge request. label May 17, 2024
@shweta83 shweta83 force-pushed the revert_subnet_fix branch from c000204 to 41ec0c2 Compare May 17, 2024 07:35
@shweta83 shweta83 added the TestFailure Issues and PRs related to a test failing in automation label May 17, 2024
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label May 17, 2024
@shweta83
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_subnet.py

@shweta83 shweta83 requested a review from Gauravtalreja1 May 17, 2024 07:36
@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 6983
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_subnet.py --external-logging
Test Result : ========= 21 passed, 18 deselected, 89 warnings in 1012.33s (0:16:52) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label May 17, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit d77637c into SatelliteQE:master May 17, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@shweta83 @web-flow
Update tests to use fixed mask (#15091)
2a21283 
(cherry picked from commit d77637c)
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@shweta83 @web-flow
Update tests to use fixed mask (#15091)
716e7df 
(cherry picked from commit d77637c)
This was referenced May 17, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@shweta83 @web-flow
Update tests to use fixed mask (#15091)
3f08652 
(cherry picked from commit d77637c)
@Satellite-QE Satellite-QE mentioned this pull request May 17, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@shweta83 @web-flow
Update tests to use fixed mask (#15091)
11c1614 
(cherry picked from commit d77637c)
@Satellite-QE Satellite-QE mentioned this pull request May 17, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@shweta83 @jyejare
Update tests to use fixed mask (SatelliteQE#15091)
07b6e59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@shweta83 shweta83

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Passed Indicates that latest PRT run is passed for the PR TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shweta83 @Satellite-QE @Gauravtalreja1