Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nailgun.entities imports in tests/foreman/longrun #15220

Merged
merged 2 commits into from
May 31, 2024
Merged

Remove nailgun.entities imports in tests/foreman/longrun #15220

merged 2 commits into from
May 31, 2024

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented May 29, 2024 •
edited
Loading

Problem Statement

SAT-22504

Uses of nailgun.entities.${ENTITY} should be replaced with ${SATELLITE_INSTANCE}.api.${ENTITY}.

Solution

All tests under tests/foreman/longrun/ now use nailgun through the satellite instance's api attribute, and imports of nailgun.entities have been removed.

Test results are the same before and after these changes, and the test failure is unrelated.

PRT:

job/robottelo-pr-testing/7183/console

14:59:31  =========================== short test summary info ============================
14:59:31  ERROR tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7] - robottelo.exceptions.CLIReturnCodeError: CLIReturnCodeError(status=70, stderr='Error: scap_content not found.\n', msg='Command "scap-content info" finished with status 70\nstderr contains:\nError: scap_content not found.\n'
14:59:31  ============= 1 passed, 45 warnings, 1 error in 903.10s (0:15:03) ==============

PRT against master:

job/robottelo-pr-testing/7213/console

09:52:46  =========================== short test summary info ============================
09:52:46  ERROR tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7] - robottelo.exceptions.CLIReturnCodeError: CLIReturnCodeError(status=70, stderr='Error: scap_content not found.\n', msg='Command "scap-content info" finished with status 70\nstderr contains:\nError: scap_content not found.\n'
09:52:46  ============= 1 passed, 46 warnings, 1 error in 1034.34s (0:17:14) =============

@tpapaioa tpapaioa self-assigned this May 29, 2024
@tpapaioa tpapaioa added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 29, 2024
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py::test_positive_noapply_api[rhel7_contenthost_module0] tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7]

1 similar comment
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py::test_positive_noapply_api[rhel7_contenthost_module0] tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7183
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py::test_positive_noapply_api[rhel7_contenthost_module0] tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7] --external-logging
Test Result : ============= 1 passed, 45 warnings, 1 error in 903.10s (0:15:03) ==============

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 29, 2024
@tpapaioa tpapaioa force-pushed the longrun_tests_remove_entities_module branch from 3672026 to e73be10 Compare May 30, 2024 13:59
@tpapaioa tpapaioa marked this pull request as ready for review May 30, 2024 14:09
@tpapaioa tpapaioa requested review from a team as code owners May 30, 2024 14:09
vsedmik
vsedmik approved these changes May 31, 2024
View reviewed changes
tests/foreman/longrun/test_inc_updates.py Outdated Show resolved Hide resolved
@tpapaioa tpapaioa force-pushed the longrun_tests_remove_entities_module branch from bf37292 to f7b7f0a Compare May 31, 2024 13:07
@tpapaioa
Copy link
Contributor Author 

trigger: test-robottelo
pytest: tests/foreman/longrun/test_inc_updates.py::test_positive_noapply_api[rhel7_contenthost_module0] tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7232
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/longrun/test_inc_updates.py::test_positive_noapply_api[rhel7_contenthost_module0] tests/foreman/longrun/test_oscap.py::test_positive_oscap_run_via_ansible[rhel7] --external-logging
Test Result : ============= 1 passed, 40 warnings, 1 error in 931.41s (0:15:31) ==============

@tpapaioa tpapaioa merged commit 8cef935 into SatelliteQE:master May 31, 2024
8 of 9 checks passed
@tpapaioa tpapaioa deleted the longrun_tests_remove_entities_module branch May 31, 2024 13:45
This was referenced May 31, 2024
Closed
Closed
Closed
tpapaioa added a commit to tpapaioa/robottelo that referenced this pull request May 31, 2024
@tpapaioa
[6.15.z] Remove nailgun.entities imports in tests/foreman/longrun (Sa…
98b0c9b 
…telliteQE#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
@tpapaioa tpapaioa mentioned this pull request May 31, 2024
Merged
tpapaioa added a commit to tpapaioa/robottelo that referenced this pull request May 31, 2024
@tpapaioa
[6.14.z] Remove nailgun.entities imports in tests/foreman/longrun (Sa…
ac0d4d8 
…telliteQE#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
@tpapaioa tpapaioa mentioned this pull request May 31, 2024
Merged
tpapaioa added a commit to tpapaioa/robottelo that referenced this pull request May 31, 2024
@tpapaioa
[6.15.z] Remove nailgun.entities imports in tests/foreman/longrun (Sa…
1020e79 
…telliteQE#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
@tpapaioa tpapaioa mentioned this pull request May 31, 2024
Merged
tpapaioa added a commit to tpapaioa/robottelo that referenced this pull request May 31, 2024
@tpapaioa
[6.13.z] Remove nailgun.entities imports in tests/foreman/longrun (Sa…
6f24767 
…telliteQE#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
tpapaioa added a commit that referenced this pull request May 31, 2024
@tpapaioa
[6.13.z] Remove nailgun.entities imports in tests/foreman/longrun (#1…
ac5780b 
…5259)

[6.13.z] Remove nailgun.entities imports in tests/foreman/longrun (#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
tpapaioa added a commit to tpapaioa/robottelo that referenced this pull request May 31, 2024
@tpapaioa
[6.14.z] Remove nailgun.entities imports in tests/foreman/longrun (Sa…
580d5f9 
…telliteQE#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
tpapaioa added a commit to tpapaioa/robottelo that referenced this pull request May 31, 2024
@tpapaioa
[6.15.z] Remove nailgun.entities imports in tests/foreman/longrun (Sa…
3136d64 
…telliteQE#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
tpapaioa added a commit that referenced this pull request May 31, 2024
@tpapaioa
[6.14.z] Remove nailgun.entities imports in tests/foreman/longrun (#1…
019ab14 
…5258)

[6.14.z] Remove nailgun.entities imports in tests/foreman/longrun (#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
tpapaioa added a commit that referenced this pull request May 31, 2024
@tpapaioa
[6.15.z] Remove nailgun.entities imports in tests/foreman/longrun (#1…
13c4edb 
…5257)

[6.15.z] Remove nailgun.entities imports in tests/foreman/longrun (#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@tpapaioa @jyejare
Remove nailgun.entities imports in tests/foreman/longrun (SatelliteQE…
77d8334 
…#15220)

* Remove nailgun.entities imports in tests/foreman/longrun

* Remove one-line helper function in longrun test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@pnovotny pnovotny pnovotny approved these changes

Assignees

@tpapaioa tpapaioa

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpapaioa @Satellite-QE @pnovotny @vsedmik