Introduce idx_prev to use as iguess #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouthEndMusic
changed the title
|
Quick benchmark: using DataInterpolations
using BenchmarkTools
N = 1000
u = rand(N)
t = cumsum(rand(N))
itp = LinearInterpolation(u, t)
t_eval = range(first(t), last(t), length = 10000)
@btime itp.(t_eval)
# old: 276.000 μs (3 allocations: 78.25 KiB)
# new: 166.600 μs (3 allocations: 78.27 KiB)So the better |
ChrisRackauckas
previously approved these changes
Jun 26, 2024
test/interpolation_tests.jl
Outdated
| for t in range(first(A.t), last(A.t); length = 2 * length(A.t) - 1) | ||
| A(t) | ||
| if hasproperty(A, :idx_prev) | ||
| @test abs(A.idx_prev[] - |
There was a problem hiding this comment.
Can this test be written with equality?
There was a problem hiding this comment.
As the kwargs of the new function get_idx show, the index is obtained in several slightly different ways. Therefore it is not possible to test the index with equality in an interpolation method agnostic way :/
| @@ -35,6 +36,11 @@ function test_derivatives(method, u, t; args = [], kwargs = [], name::String) | |||
| adiff2 = derivative(func, _t, 2) | |||
| @test isapprox(fdiff, adiff, atol = 1e-8) | |||
| @test isapprox(fdiff2, adiff2, atol = 1e-8) | |||
| # Cached index | |||
| if hasproperty(func, :idx_prev) | |||
| @test abs(func.idx_prev[] - | |||
There was a problem hiding this comment.
Can this test be written with equality?
|
@ChrisRackauckas, can you approve CI? |
sathvikbhagavan
approved these changes
Jun 29, 2024
ChrisRackauckas
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes half of #271
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.