Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEStats additon from SciMLBase #283

Merged
merged 5 commits into from
Feb 22, 2024
Merged

DEStats additon from SciMLBase #283

merged 5 commits into from
Feb 22, 2024

Conversation

H-Sax
Copy link

@H-Sax H-Sax commented Feb 22, 2024

Add any other context about the problem here.
This utilise DEStats from SciML base to allow for parallel executions of DDE

Harry Saxton added 4 commits February 22, 2024 11:25
use the Destats from SciMLBase
This has no been tested locally and should allow for parallel execution of DDE
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't follow the stats updates in SciMLBase closely, but if we should/have to switch to DEStats then I assume we can remove the DDEStats definitions completely. We should also make sure that the compat entries for SciMLBase are correct (such that DEStats is actually available).

src/solve.jl Outdated
@@ -166,7 +166,8 @@ function DiffEqBase.__init(prob::DiffEqBase.AbstractDDEProblem,
Val(isinplace(prob)))

# separate statistics of the integrator and the history
stats = DDEStats(0)
#stats = DDEStats(0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#stats = DDEStats(0)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct I should have provided more context, this change steps out of a conversation on slack
https://julialang.slack.com/archives/CN04R7WKE/p1708095479463839

@ChrisRackauckas
Copy link
Member

When JuliaRegistries/General#101462 is merged, bump the lower bound here and I'll merge when tests pass.

@devmotion
Copy link
Member

Should still remove the DDEStats implementation completely, I guess?

@ChrisRackauckas ChrisRackauckas merged commit 22fd71d into SciML:master Feb 22, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants