Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEStats additon from SciMLBase #283

Merged
merged 5 commits into from
Feb 22, 2024
Merged

DEStats additon from SciMLBase #283

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1136f88
Update solve.jl
Feb 22, 2024
2907730
Update type.jl
Feb 22, 2024
51bbafc
Update type.jl
Feb 22, 2024
97c816e
Update type.jl
Feb 22, 2024
da185b0
Remove DDEStats
devmotion Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/integrators/type.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ mutable struct DDEIntegrator{algType, IIP, uType, tType, P, eigenType, tTypeNoUn
u_modified::Bool
isdae::Bool
opts::O
stats::DDEStats
stats::SciMLBase.DEStats
history::H
differential_vars::DV
integrator::IType
Expand Down
3 changes: 2 additions & 1 deletion src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ function DiffEqBase.__init(prob::DiffEqBase.AbstractDDEProblem,
Val(isinplace(prob)))

# separate statistics of the integrator and the history
stats = DDEStats(0)
#stats = DDEStats(0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#stats = DDEStats(0)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct I should have provided more context, this change steps out of a conversation on slack
https://julialang.slack.com/archives/CN04R7WKE/p1708095479463839

stats = SciMLBase.DEStats(0)

# create solution
alg_choice = iscomposite(alg) ? Int[] : nothing
Expand Down