Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove syms and paramsyms arguments for OptimizationFuntion #644

Closed
wants to merge 1 commit into from
Closed

Remove syms and paramsyms arguments for OptimizationFuntion #644

wants to merge 1 commit into from

Conversation

sunxd3
Copy link

@sunxd3 sunxd3 commented Dec 14, 2023

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

In this PR, syms and paramsyms fields are removed from OptimizationFunction.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d53748) 0.11% compared to head (b160d13) 7.74%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #644      +/-   ##
=========================================
+ Coverage    0.11%   7.74%   +7.63%     
=========================================
  Files          40      40              
  Lines        2689    2699      +10     
=========================================
+ Hits            3     209     +206     
+ Misses       2686    2490     -196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Handled in #626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants