-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update for MTKv9 #685
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
===========================================
+ Coverage 8.65% 40.84% +32.18%
===========================================
Files 31 31
Lines 2506 2522 +16
===========================================
+ Hits 217 1030 +813
+ Misses 2289 1492 -797 ☔ View full report in Codecov by Sentry. |
1c8978f
to
4c47599
Compare
The type-piracy removal is now in #689 so it can be merged independent of MTKv9 |
Does this still need to be a draft? |
2b891ef
to
b38753c
Compare
b38753c
to
23ce471
Compare
Test failure. |
d8692c9
to
42bdfdb
Compare
MOI tests pass locally, I'm not sure why it doesn't resolve here. MTK probably doesn't pass because it isn't using the local OptimizationMOI |
@@ -19,7 +20,7 @@ Ipopt = "1" | |||
Ipopt_jll = "300.1400" | |||
Juniper = "0.9" | |||
MathOptInterface = "1" | |||
ModelingToolkit = "8.74" | |||
ModelingToolkit = "9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downgrade MOI one fails because you have removed 8.74 here but not in Optimization.jl's project.toml
Passes now! |
The docs failures look real. |
Docs are probably failing because It's using OptimizationMOI v0.1.16. Bumping MTK compat makes it use v0.1.9 which is weird. |
So I can fix compat, but CI doesn't checkout the subpackages (specifically OptimizationMOI) so they won't build here |
Also docs doesn't have compat for the latest version of
I'm trying to build docs locally by bumping compat for the first two packages and |
I'll separate this PR out into another one that contains changes independent of v9
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.