Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SSPRK methods #2264

Merged
merged 56 commits into from
Jun 30, 2024
Merged

Added SSPRK methods #2264

merged 56 commits into from
Jun 30, 2024

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
Solves a part of #2177

test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@ParamThakkar123
Copy link
Contributor Author

There are some version errors here related to the packages

@ParamThakkar123
Copy link
Contributor Author

image

I ran the runtests.jl inside OrdinaryDiffEqSSPRK and it worked.

@ChrisRackauckas
Copy link
Member

It's related to YingboMa/FastBroadcast.jl#64. Should be cleaned up in a little bit. Just branch for another set. Maybe do the Feagin next, those should be rather easy.

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas I started a new PR on #2267 for Feagin

@ParamThakkar123
Copy link
Contributor Author

But it also has the same version errors

@ChrisRackauckas
Copy link
Member

rebase to latest master

@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas

image

This error occurred in integrator_interface.jl. It could not import SSPRK22 from OrdinaryDiffEq.jl. How can I fix this ??

@ChrisRackauckas
Copy link
Member

You just need to move these functions to the lib.

https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/src/integrators/integrator_interface.jl#L118-L121

@ChrisRackauckas ChrisRackauckas merged commit 7986c8b into SciML:master Jun 30, 2024
26 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants