Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Feagin Package #2267

Merged
merged 63 commits into from
Jun 30, 2024
Merged

Added Feagin Package #2267

merged 63 commits into from
Jun 30, 2024

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
Solves a part of #2177

@ParamThakkar123 ParamThakkar123 changed the title Feagin Added Feagin Package Jun 27, 2024
@ParamThakkar123 ParamThakkar123 mentioned this pull request Jun 27, 2024
5 tasks
Project.toml Outdated
Comment on lines 4 to 5
version = "6.85.0"
version = "6.84.0"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a mistake, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made by Chris .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a mistake, right?

Not sure about that, really.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a change here ??

@ChrisRackauckas
Copy link
Member

I rebased this to latest master

@ParamThakkar123
Copy link
Contributor Author

ParamThakkar123 commented Jun 30, 2024

@ChrisRackauckas What are the other solvers that we are left to get done with after this ?? I will start with them simultaneously and solve the errors from here as well

@ChrisRackauckas
Copy link
Member

Symplectic RK and Runge Kutta Nystrom (rkn) are probably next. I'll try and do the SDIRK and FIRK, and I think that would just leave Adams methods, BDF, Verner, and Explicit RK. Almost there! Thanks so much

@ChrisRackauckas ChrisRackauckas merged commit d8c625d into SciML:master Jun 30, 2024
27 of 33 checks passed
@ParamThakkar123
Copy link
Contributor Author

@ChrisRackauckas I started a PR for symplectic methods: #2268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants