simplify issymbollike #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
reviewed
Oct 3, 2023
Co-authored-by: Christopher Rackauckas <[email protected]>
ChrisRackauckas
approved these changes
Oct 3, 2023
|
oh this is somewhat annoying this is actually a recursive dependency. We need the package extension to live in Symbolics, but that will cause problems since the versions then have to be coordinated. |
ChrisRackauckas
approved these changes
Oct 10, 2023
oscardssmith
added a commit
to oscardssmith/General
that referenced
this pull request
Oct 16, 2023
This is the last piece to get SciML/RecursiveArrayTools.jl#287 and JuliaSymbolics/Symbolics.jl#997 working.
ChrisRackauckas
pushed a commit
to JuliaRegistries/General
that referenced
this pull request
Oct 16, 2023
…#93498) This is the last piece to get SciML/RecursiveArrayTools.jl#287 and JuliaSymbolics/Symbolics.jl#997 working.
oscardssmith
added a commit
that referenced
this pull request
Oct 18, 2023
#287 was actually a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure this is correct, but it is a lot cleaner. It's also somewhat unclear to me why the Symbolics.jl types are getting hacked around here rather than having Symbolics overload
issymbollike(possibly with a package extension).