Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify issymbollike #287

Merged
merged 5 commits into from
Oct 10, 2023
Merged

simplify issymbollike #287

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f439776
simplify issymbollike
oscardssmith Oct 3, 2023
5e55510
re-add __parameterless_type
oscardssmith Oct 3, 2023
b84900a
move to package extension
oscardssmith Oct 3, 2023
2e2afb6
Update ext/RecursiveArrayToolsSymbolicsExt.jl
oscardssmith Oct 3, 2023
7eb5df9
remove extension
oscardssmith Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/vector_of_array.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,10 @@ end
struct AllObserved
end

Base.@pure __parameterless_type(T) = Base.typename(T).wrapper
oscardssmith marked this conversation as resolved.
Show resolved Hide resolved

@generated function issymbollike(x)
x <: Union{Symbol, AllObserved} && return quote true end
ss = ["Operation", "Variable", "Sym", "Num", "Term"]
s = string(Symbol(__parameterless_type(x)))
bool = any(x -> occursin(x, s), ss)
quote
$bool
end
function issymbollike(x)
x isa Union{Symbol, AllObserved} && return true
oscardssmith marked this conversation as resolved.
Show resolved Hide resolved
ss = (:Operation, :Variable, :Sym, :Num, :Term)
return typeof(x).name.name in ss
end

function Base.Array(VA::AbstractVectorOfArray{T, N, A}) where {T, N,
Expand Down