Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional continuous_modification argument to reeval_internals_due_to_modification! #625

Merged

Conversation

oscardssmith
Copy link
Contributor

When set to false allows the integrator to skip recalculating the interpolation data. This is a prereq to SciML/OrdinaryDiffEq.jl#2141 being finished.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

…_to_modification! that when set to false allows the integrator to skip recalculating the interpolation data
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f457edc) 26.33% compared to head (3ef766a) 26.32%.

Files Patch % Lines
src/integrator_interface.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   26.33%   26.32%   -0.02%     
==========================================
  Files          55       55              
  Lines        4249     4251       +2     
==========================================
  Hits         1119     1119              
- Misses       3130     3132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit eca78b8 into SciML:master Feb 14, 2024
28 of 42 checks passed
@oscardssmith oscardssmith deleted the os/reeval_internals-improvements branch February 14, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants