Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix remake for symbolic indexing, add tests for remake #644

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 61.90476% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 38.53%. Comparing base (21e7460) to head (30c96ab).
Report is 2 commits behind head on master.

Files Patch % Lines
src/remake.jl 61.90% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   37.54%   38.53%   +0.99%     
==========================================
  Files          55       55              
  Lines        4294     4287       -7     
==========================================
+ Hits         1612     1652      +40     
+ Misses       2682     2635      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

It looks like a lot of tests are failing here?

@AayushSabharwal
Copy link
Member Author

Hopefully this fixes them. There are a bunch of edge cases with remake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants