Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't rely on RAT internals in EnsembleSolution indexing #687

Merged
merged 1 commit into from
May 9, 2024
+1 −2
Merged

fix: don't rely on RAT internals in EnsembleSolution indexing #687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/ensemble/ensemble_solutions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,7 @@
end
end

Base.@propagate_inbounds function RecursiveArrayTools._getindex(
x::AbstractEnsembleSolution, ::Union{ScalarSymbolic, ArraySymbolic}, s, ::Colon)
Base.@propagate_inbounds function Base.getindex(x::AbstractEnsembleSolution, s, ::Colon)

Check warning on line 214 in src/ensemble/ensemble_solutions.jl

View check run for this annotation

Codecov / codecov/patch

src/ensemble/ensemble_solutions.jl#L214 

Added line #L214 was not covered by tests
return [xi[s] for xi in x.u]
end

Expand Down
Loading