Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliasing API types #830

Merged
merged 20 commits into from
Dec 13, 2024
Merged

Conversation

jClugstor
Copy link
Contributor

Checklist

  • [ x] Appropriate tests were added
  • [ x] Any code changes were done in a way that does not break public API
  • [ x] All documentation related to code changes were updated
  • [ x] The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • [ x] Any new documentation only uses public API

Additional context

This adds the abstract type AbstractAliasSpecifier and the concrete subtypes ODEAliases and LinearAliases meant to hold information on which variables to alias when solving the problems. When an alias specifier is true, that variable is aliased, and vice versa for false. When the alias specifier is nothing, the solvers default behavior is used.

Also bumps the minor version since this is a new feature.

@ChrisRackauckas
Copy link
Member

what's next here?

@jClugstor
Copy link
Contributor Author

I still need to make sure that every problem has an associated AliasSpecifier and constructor. Then I can go through each package that uses the problems and make sure they use the AliasSpecifier.

That's mostly done for LinearSolve, NonlinearSolve, and OrdinaryDiffEq.

Actually, if we need to be able to use it to decide whether to alias jac_prototypes for OrdinaryDiffEq implicit solvers that might take some refactoring that will take longer.

@ChrisRackauckas ChrisRackauckas merged commit 97a79f7 into SciML:master Dec 13, 2024
28 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants