feat: add new remake(::AbstractSciMLFunction), fix some remake bugs.
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/fix-mtk-tests
branch
from
0be8edc to
6c15292
Compare
AayushSabharwal
force-pushed
the
as/fix-mtk-tests
branch
from
dd16264 to
d455a5a
Compare
|
Formatting issues are on master, will make a separate PR to fix them to avoid confusing the intent of this one. |
Comment on lines
+102
to
+116
| """ | ||
| $(TYPEDSIGNATURES) | ||
|
|
||
| A utility function which merges two `NamedTuple`s `a` and `b`, assuming that the | ||
| keys of `a` are a subset of those of `b`. Values in `b` take priority over those | ||
| in `a`, except if they are `nothing`. Keys not present in `a` are assumed to have | ||
| a value of `nothing`. | ||
| """ | ||
| function _similar_namedtuple_merge_ignore_nothing(a::NamedTuple, b::NamedTuple) | ||
| ks = fieldnames(typeof(b)) | ||
| return NamedTuple{ks}(ntuple(Val(length(ks))) do i | ||
| something(get(b, ks[i], nothing), get(a, ks[i], nothing), Some(nothing)) | ||
| end) | ||
| end | ||
|
|
There was a problem hiding this comment.
isn't this just (;a..., b...)?
There was a problem hiding this comment.
No, because nothing values in b will override values in a. This function makes it so that if a key has the value nothing in b, it uses the value from a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.