-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ScopeLift foundry default settings to repo #14
Conversation
e532662
to
650aaad
Compare
650aaad
to
6e2a4e5
Compare
4801479
to
44f08ed
Compare
e1dc1e2
to
56804a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
single_line_statement_blocks = "multi" | ||
tab_width = 4 | ||
wrap_comments = true | ||
ignore = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious, why mark these as ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of the original contracts got modified by "forge fmt" and adding them to the ignore list allows them to not show up as large diffs on the PR.
* Configured foundry/hardhat compatibility * Add empty placeholder governor and test contract to verify forge install is working * Added foundry.toml defaults for testing and formatting (original contracts not formatted) * Add forge install to test.yml * Updated hardhat plugin to latest to resolve coverage issue * Switched proposer address in fork tests to one with some voting power * prettier fix .. need for this triggered by previous commit ts file change
Resolves #1
This PR aadds the default Foundry/Forge configuration used by ScopeLift to the repo, which will be used for the development of the new CompoundGovernor. This configuration will co-exist with the hardhat environment used for developing the earlier GovernorBravo contracts. To achieve this coexistence, the node library
hardhat-foundry
is installed by this PR, as described here.To minimize style/formatting differences, the previously existing contract source files have been added to the "ignore" section of the formatter section of the
foundry.toml
file.Additionally, an empty
CompoundGovernor.sol
andCompoundGovernor.t.sol
file have been added to the repo, in thecontracts
, andcontracts/test
directories respectively, to satisfy execution of the forge build and test commands.