forked from compound-finance/compound-governance
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ScopeLift foundry default settings to repo #14
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
156a44e
Configured foundry/hardhat compatibility
jferas 50f9282
Add empty placeholder governor and test contract to verify forge inst…
jferas 6e2a4e5
Added foundry.toml defaults for testing and formatting (original cont…
jferas 44f08ed
Add forge install to test.yml
jferas a49d84c
Updated hardhat plugin to latest to resolve coverage issue
jferas 56804a7
Switched proposer address in fork tests to one with some voting power
jferas 27cd81f
prettier fix .. need for this triggered by previous commit ts file ch…
jferas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,5 @@ cache | |
artifacts | ||
yarn-error.log | ||
.DS_Store | ||
cache_forge | ||
out |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "lib/forge-std"] | ||
path = lib/forge-std | ||
url = https://github.com/foundry-rs/forge-std |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,6 @@ artifacts | |
cache | ||
coverage* | ||
contracts* | ||
typechain-types | ||
typechain-types | ||
out | ||
lib |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// SPDX-License-Identifier: BSD-3-Clause | ||
pragma solidity 0.8.18; | ||
|
||
// TODO: Implement new governance contract for Compound. This is just a placeholder to satisfy "forge fmt". | ||
contract CompoundGovernor {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// SPDX-License-Identifier: BSD-3-Clause | ||
pragma solidity 0.8.18; | ||
|
||
import {Test, console2} from "forge-std/Test.sol"; | ||
|
||
// TODO: implement actual CompoundGovernor tests. This is just a placeholder to satisfy "forge test". | ||
contract CompoundGovernorTest is Test { | ||
function test() public pure { | ||
assertEq(true, true); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
[profile.default] | ||
src = 'contracts' | ||
out = 'out' | ||
libs = ['node_modules', 'lib'] | ||
test = 'test' | ||
cache_path = 'cache_forge' | ||
evm_version = "shanghai" | ||
optimizer = true | ||
optimizer_runs = 10_000_000 | ||
solc_version = "0.8.18" | ||
verbosity = 3 | ||
|
||
[profile.ci] | ||
fuzz = { runs = 5000 } | ||
invariant = { runs = 1000 } | ||
|
||
[profile.lite] | ||
fuzz = { runs = 50 } | ||
invariant = { runs = 10 } | ||
# Speed up compilation and tests during development. | ||
optimizer = false | ||
|
||
[invariant] | ||
call_override = false | ||
depth = 100 | ||
dictionary_weight = 80 | ||
fail_on_revert = false | ||
include_push_bytes = true | ||
include_storage = true | ||
optimizer = false | ||
runs = 25 | ||
|
||
[fmt] | ||
bracket_spacing = false | ||
int_types = "long" | ||
line_length = 120 | ||
multiline_func_header = "attributes_first" | ||
number_underscore = "thousands" | ||
quote_style = "double" | ||
single_line_statement_blocks = "multi" | ||
tab_width = 4 | ||
wrap_comments = true | ||
ignore = [ | ||
"contracts/Comp.sol", | ||
"contracts/GovernorBravo*.sol", | ||
"contracts/SafeMath.sol", | ||
"contracts/Timelock.sol", | ||
"contracts/test/GovernorAlpha.sol", | ||
"contracts/test/Multicall.sol" | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious, why mark these as ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of the original contracts got modified by "forge fmt" and adding them to the ignore list allows them to not show up as large diffs on the PR.