Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: running the goat locally #198

Merged
merged 3 commits into from
Jun 4, 2024
Merged

fix: running the goat locally #198

merged 3 commits into from
Jun 4, 2024

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Jun 4, 2024

Contributor Comments

This fixes a regression from e40e851 where it checks for a github action-only variable in a way that fails the overall workload.

Manual testing

Tested it locally with a task build and task lint which now works but when testing I had to temporarily remove the following otherwise it would pull from docker hub and overwrite the local build

goat/Task/Taskfile.yml

Lines 99 to 102 in f5005e6

preconditions:
- sh: |
docker pull seiso/goat:latest || \
echo "Failed to pull the goat, continuing anyway..."

Pull Request Checklist

Thank you for submitting a contribution to our project!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch.
  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • If there is an issue associated with your Pull Request, link the issue to the PR.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

entrypoint.sh Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salacious has reviewed your code, please see inline comments.

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@JonZeolla JonZeolla enabled auto-merge (squash) June 4, 2024 21:28
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salacious has reviewed your code, please see inline comments.

Dockerfile Show resolved Hide resolved
Copy link
Contributor

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla merged commit 0ced2d6 into main Jun 4, 2024
3 checks passed
@JonZeolla JonZeolla deleted the fix-local-running branch June 4, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants