Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: running the goat locally #198

Merged
merged 3 commits into from
Jun 4, 2024
Merged

fix: running the goat locally #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd25eac
fix: running the goat locally
JonZeolla Jun 4, 2024
570a62c
Fixup
JonZeolla Jun 4, 2024
16cbb05
Fix cleanup so local linting doesn't take forever
JonZeolla Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
# syntax=docker/dockerfile:1

# TARGETPLATFORM is special cased by docker and doesn't need the inital ARG
# TARGETPLATFORM is special cased by docker and doesn't need the initial ARG
# https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope
JonZeolla marked this conversation as resolved.
Show resolved Hide resolved
FROM --platform=$TARGETPLATFORM ghcr.io/yannh/kubeconform:v0.6.3 as kubeconform
FROM --platform=$TARGETPLATFORM ghcr.io/yannh/kubeconform:v0.6.6-alpine as kubeconform
JonZeolla marked this conversation as resolved.
Show resolved Hide resolved
ARG TARGETPLATFORM
JonZeolla marked this conversation as resolved.
Show resolved Hide resolved
FROM --platform=$TARGETPLATFORM hadolint/hadolint:v2.12.0-alpine as hadolint
ARG TARGETPLATFORM
FROM --platform=$TARGETPLATFORM koalaman/shellcheck:v0.9.0 as shellcheck
FROM --platform=$TARGETPLATFORM koalaman/shellcheck:v0.10.0 as shellcheck
ARG TARGETPLATFORM
FROM --platform=$TARGETPLATFORM rhysd/actionlint:1.6.25 as actionlint
FROM --platform=$TARGETPLATFORM rhysd/actionlint:1.7.1 as actionlint

ARG TARGETPLATFORM
FROM --platform=$TARGETPLATFORM python:3.11-alpine3.18 as base_image
FROM --platform=$TARGETPLATFORM python:3.11-alpine3.20 as base_image

ENV LANG=C.UTF-8
ENV LC_ALL=C.UTF-8
Expand Down
1 change: 1 addition & 0 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ tasks:
desc: Clean up build artifacts, cache files/directories, temp files, etc.
cmds:
- task: bash:clean
- rm -rf {{.ROOT_DIR}}/node_modules

release:
desc: Cut a project release
Expand Down
2 changes: 1 addition & 1 deletion entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ function rerun_lint() {
}

function initiate_code_review() {
if [ -n "$GITHUB_ACTIONS" ]; then
if [[ -n ${GITHUB_ACTIONS:+x} ]]; then
JonZeolla marked this conversation as resolved.
Show resolved Hide resolved
# Run the Python script
python /opt/goat/bin/code_review.py
fi
Expand Down