-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multisearch + dynamic filters V2 #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdadc6b
to
807871f
Compare
loevgaard
reviewed
Aug 30, 2024
loevgaard
reviewed
Aug 30, 2024
loevgaard
reviewed
Aug 30, 2024
loevgaard
reviewed
Aug 30, 2024
loevgaard
reviewed
Aug 30, 2024
67ddb15
to
fdaa6e9
Compare
loevgaard
reviewed
Aug 30, 2024
loevgaard
reviewed
Aug 30, 2024
loevgaard
reviewed
Aug 31, 2024
b369809
to
b32519d
Compare
loevgaard
reviewed
Sep 2, 2024
{% block setono_sylius_meilisearch_facet_range_row %} | ||
<div class="facet facet-range"> | ||
{{ form_label(form) }} | ||
<div class="ui small labeled input" style="margin-bottom: 1rem;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually didn't use any Semantic CSS markup because I reckon nobody uses it, so by not using it, maybe, just maybe they won't have to override this file :D
You don't have to fix it. I can just fix it in another PR :)
b32519d
to
3e70ae9
Compare
3e70ae9
to
fe6915e
Compare
…\MetadataInterface::getFacetableAttributeNames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #17
In the beginning, I wanted to separate those concepts, as I already wrote to @loevgaard... but as I started the refactor and improvements on #17 it was eventually hard (and potentially time-consuming) to come back to the single search feature. Therefore, I decided to left them coupled to each other, I hope the PR is not too big (spoiler alert: it will be xD 💃)
The main things that were done in this PR:
SearchEngine
refactoring (see to-dos)#[Facet]
attribute on the documented entity. The type of the filter is generic, based on the type of the property, which does not have to be defined in the attribute (it's taken from the property/method reflection data)#[Facet]
attribute)The current functionality is shown in the video below:
Nagranie.z.ekranu.2024-08-30.o.14.30.36.mov
What is left to be done:
SearchEngine
fully (there are a couple of private methods there, each of them could and should be a separate service)SearchTest
🖖