Merge code for applying sensorOffset and setting data ready flag
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
approved these changes
Mar 8, 2024
nekomona
force-pushed
the
sensor-offset-patch
branch
from
7bf7b56 to
d32eb62
Compare
TheDevMinerTV
approved these changes
Mar 28, 2024
Eirenliel
approved these changes
Mar 28, 2024
l0ud
pushed a commit
to l0ud/SlimeVR-Tracker-ESP-BMI270
that referenced
this pull request
Apr 1, 2024
…limeVR#314) Merge applying of sensorOffset and data ready flag Co-authored-by: nekomona <[email protected]>
Meeman77
pushed a commit
to Meeman77/SlimeVR-Tracker-ESP
that referenced
this pull request
May 1, 2024
…limeVR#314) Merge applying of sensorOffset and data ready flag Co-authored-by: nekomona <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous codes have ambiguity in when to computing delta angle for update check:
sensorOffset(e.g. BMI160)SlimeVR-Tracker-ESP/src/sensors/bmi160sensor.cpp
Lines 364 to 370 in b744c53
SlimeVR-Tracker-ESP/src/sensors/icm42688sensor.cpp
Lines 175 to 179 in b744c53
This PR set the applying of
sensorOffsetto be a common behavior before computing delta angle and setting the ready flag, removing the duplicated code distributed in each sensor's class.With this PR, the update to
fusedQuaternionandaccelerationare also limited tosetFusedRotationandsetAccelerationmethods, which may simplify future modifications for multi-threading.