Primary render fallback #1680
Open
Primary render fallback #1680
+336
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
from
d2f7e1f to
4b808ab
Compare
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
2 times, most recently
from
427b2ce to
05ee0b7
Compare
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
from
05ee0b7 to
57aacfc
Compare
cmeissl
force-pushed
the
feature/primary_render_fallback
branch
from
57aacfc to
16c1a0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1680 +/- ##
==========================================
+ Coverage 17.10% 19.14% +2.04%
==========================================
Files 174 174
Lines 28748 28767 +19
==========================================
+ Hits 4916 5508 +592
+ Misses 23832 23259 -573
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmeissl
commented
Mar 22, 2025
Comment on lines
+98
to
+102
| #[cfg(feature = "backend_drm")] | ||
| pub fn from_bo(bo: BufferObject<()>, implicit: bool) -> Self { | ||
| let drm_node = DrmNode::from_file(bo.device_fd()).ok(); | ||
| Self::from_bo_with_node(bo, implicit, drm_node) | ||
| } |
There was a problem hiding this comment.
I do not like all those conditional compilation around backend_drm here. Do we really want to do this or should we just enable backend_drm for backend_gbm implicitely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for display only nodes by falling back to the primary gpu for rendering.
In addition to the render fallback it also tries to import foreign gbm buffers through dmabuf export/import.
Unfortunately it seems the DisplayLink driver has some issues regarding vsync and will issue a vblank right after
scheduling a page flip. This leads to visual tearing, probably caused by the user-space driver part. As a mitigation this PR also adds a way to throttle vblanks.