Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API for Point and Layer data #81

Merged
merged 38 commits into from
Jun 17, 2024
Merged

API for Point and Layer data #81

merged 38 commits into from
Jun 17, 2024

Conversation

micah-prime
Copy link
Contributor

@micah-prime micah-prime commented May 23, 2024 •
edited
Loading

Coverage Badge

  • This is the MVP for the API. It covers Point and Layer data with standardized functions
  • DB connection completely handled behind the scenes
  • Data returned as GeoPandas dataframes
  • .from_filter and .from_area methods for accessing data
  • Documentation
  • Example notebooks

TODO:

  • Get plotly plots working in readthedocs
  • Update .readthedocs file since schema changed since last build

@micah-prime micah-prime self-assigned this May 23, 2024
@micah-prime micah-prime marked this pull request as ready for review June 3, 2024 21:56
@micah-prime
Copy link
Contributor Author

We will have to upgrade to sqlalchemy > 2.0. This is not difficult in this library, but I'm sure there will be nuance for the builder

https://gitlab.com/ars-snow/ipw/-/commits/master/src/bin/phys.pt/albedo?ref_type=heads

@micah-prime
Copy link
Contributor Author

@micahjohnson150 a million little tweaks later, this is building again, tests are running successfully, and the docs are building!

Ready for your review and I think we can check off the MVP of the API 💥

micahjohnson150
micahjohnson150 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@micahjohnson150 micahjohnson150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation!!!

@micah-prime micah-prime merged commit 4f8fba4 into master Jun 17, 2024
10 checks passed
@micah-prime micah-prime deleted the api branch June 17, 2024 21:57
@micahjohnson150 micahjohnson150 mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahjohnson150 micahjohnson150 micahjohnson150 approved these changes

Assignees

@micah-prime micah-prime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micah-prime @micahjohnson150