feat: add a polling timeout #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property timeout-minutes in a GitHub step is not supported in composed actions. So the workaround to stop the waiting for finishing the sonar scan is not working in such cases. To fix this issue, a polling timeout variable was introduced, which stops the waiting, if the timout is reached.
|
Hey @MueChr. Thank you for your contribution. Did you have a chance to look at @jacek-poreda-sonarsource's request? :) |
|
Hi @davividal, thank you for the reminder. I applied the change. So from my side it is ready for the merge :) |
|
@MueChr It seems like unit tests have failed; could you update it? Apart from that PR looks good 👍 |
…eached The code never sets a quality-gate-status, if the polling timeout is reached. Interestingly, it did not display an error when the tests were run locally.
jacek-poreda-sonarsource
approved these changes
Aug 30, 2024
|
@MueChr Thanks a lot for your contribution! |
github-merge-queue bot
pushed a commit
to dotCMS/core
that referenced
this pull request
Sep 5, 2024
### Proposed Changes * Fix the action to the current commit https://github.com/sonarsource/sonarqube-quality-gate-action/tree/dc2f7b0dd95544cd550de3028f89193576e958b9 for reproducability instead of auto updting any change to master branch. Includes the timeout change in this PR SonarSource/sonarqube-quality-gate-action#50 * * set the new pollingTimeoutSec to 600 (e.g. 10 minutes) To test, check the logs of the build run in the sonarqube step and it should show the timeout passed in as "600" instead of "300" ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info This PR resolves #29886 (Fix SonarQube timeout property). ### Screenshots Original | Updated :-------------------------:|:-------------------------: ** original screenshot ** | ** updated screenshot **
dsolistorres
pushed a commit
to dotCMS/core
that referenced
this pull request
Sep 18, 2024
### Proposed Changes * Fix the action to the current commit https://github.com/sonarsource/sonarqube-quality-gate-action/tree/dc2f7b0dd95544cd550de3028f89193576e958b9 for reproducability instead of auto updting any change to master branch. Includes the timeout change in this PR SonarSource/sonarqube-quality-gate-action#50 * * set the new pollingTimeoutSec to 600 (e.g. 10 minutes) To test, check the logs of the build run in the sonarqube step and it should show the timeout passed in as "600" instead of "300" ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info This PR resolves #29886 (Fix SonarQube timeout property). ### Screenshots Original | Updated :-------------------------:|:-------------------------: ** original screenshot ** | ** updated screenshot **
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property timeout-minutes in a GitHub step is not supported in composed actions. So the workaround to stop the waiting for finishing the sonar scan is not working in such cases. To fix this issue, a polling timeout variable was introduced, which stops the waiting, if the timeout is reached.