Feat/auto hsv calibration #18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clude it from the mask, as we only have one mask, and don't need separate colors for everything
theoretically, no idea if it works, probably doesn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not fully automatic, but basically you line the box on the UI up with something (e.g. a white piece of paper, the ramp, the ground, etc) and click either "include" or "exclude" from the mask on the UI, and it does some automatic stuff to adjust the HSV threshold values as necessary. this would replace the whole guess/check method and also make it so we don't need Noah running around with a webcam and a color picker program on a laptop.