-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid using CPU generation without CPU vendor #364
Forbid using CPU generation without CPU vendor #364
Conversation
Signed-off-by: Anja Strunk <[email protected]>
Signed-off-by: Anja Strunk <[email protected]>
This way it is very difficult to see what has changed. Can you please add a diff (v3 vs v4) as a comment? |
I'm not sure, if these two additional sentences entitle a new version of Flavor Naming Standard. Maybe they are just a minor improvement of version 3. |
From my POV, we problem is the following. I quote lines 301 and following:
There are fewer closing brackets than opening ones. Also, at the beginning of the section entitled Now, my problem is that -- due to the missing closing bracket -- I can't really tell what was meant there. I guess, though, that the closing bracket has to be added to the end of this part:
And then, the problem should be gone! Pooff! I think this counts as a minor edit, which can be done inside v3. I will ask Kurt to comment though. |
You are right, we are missing a closing bracket, as you say. (You can compare the python tool output if you like.) |
All right, I will update PR accordingly. |
Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
Signed-off-by: Matthias Büchse <[email protected]>
c7c9966
to
7c57dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Though reading, I spotted a mistake in line 410 (which is unchanged by you). I'll submit a separate PR for it unless you want to address it (and change a z
to an i
or adjust the description to read AMD Milan instead of Intel Ice Lake.
…using-cpu-generation-without-specifying-cpu-vendor
closes #363