Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid using CPU generation without CPU vendor #364

Conversation

anjastrunk
Copy link
Contributor

closes #363

@anjastrunk anjastrunk added bug Something isn't working SCS-VP10 Related to tender lot SCS-VP10 labels Oct 20, 2023
@anjastrunk anjastrunk self-assigned this Oct 20, 2023
@anjastrunk anjastrunk linked an issue Oct 20, 2023 that may be closed by this pull request
Signed-off-by: Anja Strunk <[email protected]>
@berendt
Copy link
Contributor

berendt commented Oct 20, 2023

This way it is very difficult to see what has changed. Can you please add a diff (v3 vs v4) as a comment?

@anjastrunk
Copy link
Contributor Author

anjastrunk commented Oct 23, 2023

This way it is very difficult to see what has changed. Can you please add a diff (v3 vs v4) as a comment?

git diff --no-index scs-0100-v3-flavor-naming.md scs-0100-v4-flavor-naming.md 
diff --git a/scs-0100-v3-flavor-naming.md b/scs-0100-v4-flavor-naming.md
index 4d4447a..b1823b0 100644
--- a/scs-0100-v3-flavor-naming.md
+++ b/scs-0100-v4-flavor-naming.md
@@ -1,10 +1,10 @@
 ---
 title: SCS Flavor Naming Standard
 type: Standard
-status: Stable
-stabilized_at: 2023-06-14
+status: Draft
+stabilized_at: 
 track: IaaS
-replaces: scs-0100-v2-flavor-naming.md
+replaces: scs-0100-v3-flavor-naming.md
 ---
 
 ## Introduction
@@ -360,6 +360,7 @@ The generations are vendor specific and can be left out.
 Not specifying arch means that we have a generic CPU (**x86-64**).
 The letters `i`, `z`, `a` and `r` specify the vendors Intel,
 AMD (`z` like in Zen), ARM v8+, RISC-V.
+Each generation number MUST be prefixed by a letter for CPU vendor. It is forbidden to just use a generation number.
 
 | Generation | i (Intel x86-64) | z (AMD x86-64) |  a (AArch64)       | r (RISC-V) |
 | ---------- | ---------------- | -------------- | ------------------ | ---------- |
@@ -394,6 +395,7 @@ out when generating the name for comparison. In other words: 0 has a meaning of
 - SCS-2C-4-10n_bms_**z3**
 - SCS-2C-4-10n_bms_**z3h**
 - SCS-2C-4-10n_bms_**z3hh** <- Bare Metal, Intel Ice Lake with > 3.25GHz all core freq
+- ~~SCS-2C-4-10n\_**3**~~ <- illegal, missing letter for CPU vendor
 
 ### [OPTIONAL] GPU support

I'm not sure, if these two additional sentences entitle a new version of Flavor Naming Standard. Maybe they are just a minor improvement of version 3.

@mbuechse
Copy link
Contributor

From my POV, we problem is the following. I quote lines 301 and following:

The extensions have the format:

\[`_`hyp\]\[`_hwv`\]\[`_`\[arch\[N\]\[`h`\]\[`_`\[`G/g`\]X\[N\]\[`-`M\[`h`\]\]\]\[`_ib`\]

There are fewer closing brackets than opening ones. Also, at the beginning of the section entitled ### [OPTIONAL] CPU Architecture Details the relevant part of the above format should be repeated, as is done for other sections.

Now, my problem is that -- due to the missing closing bracket -- I can't really tell what was meant there. I guess, though, that the closing bracket has to be added to the end of this part:

\[`_`\[arch\[N\]\[`h`\]

And then, the problem should be gone! Pooff! I think this counts as a minor edit, which can be done inside v3. I will ask Kurt to comment though.

@garloff
Copy link
Member

garloff commented Oct 26, 2023

You are right, we are missing a closing bracket, as you say. (You can compare the python tool output if you like.)
And yes, clarifications and fixed typos should not make us change the version number. (Unless the typo resulted in wrong names out in the wild.)

@anjastrunk
Copy link
Contributor Author

You are right, we are missing a closing bracket, as you say. (You can compare the python tool output if you like.) And yes, clarifications and fixed typos should not make us change the version number. (Unless the typo resulted in wrong names out in the wild.)

All right, I will update PR accordingly.

@mbuechse mbuechse requested review from garloff and removed request for mbuechse October 27, 2023 18:47
@mbuechse mbuechse force-pushed the 363-bug-scs-flavor-standard-does-not-forbid-using-cpu-generation-without-specifying-cpu-vendor branch from c7c9966 to 7c57dfe Compare November 3, 2023 15:25
Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though reading, I spotted a mistake in line 410 (which is unchanged by you). I'll submit a separate PR for it unless you want to address it (and change a z to an i or adjust the description to read AMD Milan instead of Intel Ice Lake.

…using-cpu-generation-without-specifying-cpu-vendor
@garloff garloff merged commit 03d02fe into main Nov 3, 2023
4 checks passed
@garloff garloff deleted the 363-bug-scs-flavor-standard-does-not-forbid-using-cpu-generation-without-specifying-cpu-vendor branch November 3, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SCS-VP10 Related to tender lot SCS-VP10
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Extension syntax in flavor naming standard misleading
4 participants